Evergreen

backdating checkins to the future should not be allowed

Bug #1016204 reported by Thomas Berezansky on 2012-06-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Evergreen	Fix Released	Medium	Unassigned	Evergreen 2.6.0-beta1
	2.5	Fix Released	Undecided	Unassigned	Evergreen 2.5.3

Bug Description

Instead of trying to teach SIP2 to not backdate checkins to the future the branch below teaches the circ module to treat them as not backdated at all.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/no_future_checkin

Tags:

Jason Stephenson (jstephenson) on 2012-12-13

Changed in evergreen:
status:	New → Triaged

Ben Shum (bshum) on 2013-03-17

Changed in evergreen:
milestone:	none → 2.4.0-rc

Ben Shum (bshum) on 2013-04-27

Changed in evergreen:
milestone:	2.4.0-rc → 2.5.0-alpha

Dan Wells (dbw2) on 2013-06-13

Changed in evergreen:
milestone:	2.5.0-m1 → 2.5.0-m2

Dan Wells (dbw2) on 2013-07-15

Changed in evergreen:
milestone:	2.5.0-m2 → 2.5.0-alpha1

Remington Steed (rjs7) on 2013-08-12

Changed in evergreen:
milestone:	2.5.0-alpha1 → 2.5.0-alpha2

Dan Wells (dbw2) on 2013-08-26

Changed in evergreen:
milestone:	2.5.0-alpha2 → 2.5.0-beta1

Dan Wells (dbw2) on 2013-09-29

Changed in evergreen:
milestone:	2.5.0-beta1 → 2.5.0-rc

Dan Wells (dbw2) on 2013-10-16

Changed in evergreen:
milestone:	2.5.0-rc → 2.5.1

Ben Shum (bshum) on 2013-12-06

Changed in evergreen:
milestone:	2.5.1 → 2.5.2
importance:	Undecided → Medium

Dan Wells (dbw2) on 2014-01-17

Changed in evergreen:
milestone:	2.5.2 → 2.6.0-alpha1

Revision history for this message

Dan Wells (dbw2) wrote on 2014-02-05:

Changed the title, since this code isn't really SIP specific, and hopefully the change will cause it to get more eyes.

Changed in evergreen:
milestone:	2.6.0-alpha1 → 2.6.0-beta1
summary:	- SIP2 can backdate to the future + backdating checkins to the future should not be allowed

Revision history for this message

Ben Shum (bshum) wrote on 2014-02-14:

When I tried to apply this change, I got a conflict in the file. Looks like when http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7a7c229db5044712ad44ad5a75ca7a65cd6d9105 was merged, the code here was shuffled a tiny bit.

Marking as "incomplete" and assigning back to tsbere to do some light rebasing with the changes here.

Changed in evergreen:
status:	Triaged → Incomplete
assignee:	nobody → Thomas Berezansky (tsbere)

Revision history for this message

Thomas Berezansky (tsbere) wrote on 2014-02-14:

I pushed a rebased variant to correct the issue.

Changed in evergreen:
assignee:	Thomas Berezansky (tsbere) → nobody
status:	Incomplete → Triaged

Ben Shum (bshum) on 2014-02-15

Changed in evergreen:
status:	Triaged → Fix Committed

Evergreen Bug Maintenance (bugmaster) on 2014-06-26

Changed in evergreen:
status:	Fix Committed → Fix Released

Evergreen Bug Maintenance (bugmaster) on 2016-08-16

no longer affects:

evergreen/2.4

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.