tpac: public copy notes do not display in tpac

[Kathy Lussier]

Evergreen version: 2.2 RC1

Public copy notes should display on the record details page.

[Bob Wicksall (bwicksall)]

We can confirm this in version 2.2.0. It would be nice to see this feature added.

[Jessie M. Bunker-Maxwell (jessb)]

In version 2.0.10, item copy notes displayed in Holdings Maintenance; when using "Edit Item Attributes"; and in the PAC when looking at "More information" for copy details.

Since our upgrade to 2.3, we realized that the display of item copy notes remains only in "Edit Item Attributes" where it is buried quite a ways down in the item record.

This display was of much use to staff via the PAC and Holdings Maintenance because it was more easily accessible.

We would like to see this display option re-instated.

Santa Cruz Public Library

[edoceo (edoceo)]

This might be fixed in Master?

Here is the branch that does it
  http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/edoceo/lp1013817

This shows what that commit looks like
  http://demo.ils.edoceo.com/eg/opac/record/8

[edoceo (edoceo)]

Sorry, that should read - fixed AGAINST master - not in master, and attached is a patch for this too.

[Michael Peters (mrpeters)]

I've installed this to a server running the latest master and it's working excellent!

Signed off @
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/lp1013817_signoff

Can be tested on http://dev.evergreen.lib.in.us

Example: https://dev.evergreen.lib.in.us/eg/opac/record/5430326?contains=contains;_special=1;qtype=item_barcode;query=0000101664944;locg=1;copy_offset=0;copy_limit=50

[Dan Scott (denials)]

Hi David: Can you please clean up the commit history so that you don't introduce code that you then comment in a subsequent commit and then delete in a commit after that? Then add a "pullrequest" tag when it's ready to commit to master. (FWIW, a quick look at the final product seems okay.)

[Michael Peters (mrpeters)]

I've tested David's code on some records with many copies and performance is still strong.

Example -- 71 copies, many notes.

http://dev.evergreen.lib.in.us/eg/opac/record/16744791?query=title%3ATime%20bib_level%28s%29;qtype=keyword;locg=73;_adv=1;page=0

[edoceo (edoceo)]

Dan, here's the cleaned up commit

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/edoceo/lp1013817-clean

[Mike Rylander (mrylander)]

We lost Mike Peter's sign-off in the squashing, but the code is unchanged. Merged to master for 2.4. Thanks, edoceo!