Patron OPAC Visible Notes not showing in TPAC

Bug #1010590 reported by Shae
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

In testing for a customer and then again on an in house system (at 2.2. rc1), it looks like OPAC visible notes for the patron are not showing anywhere in the TPAC. Steps for recreating this:

1. Retrieve a patron in staff client.
2. Add a note, checking the OPAC visible option.
3. Go to the TPAC and log in as that user.

I checked all of the tabs and all over the screen. I don't see the note anywhere. Shows fine if I switch to the original OPAC My Account view.

Thanks!

Revision history for this message
Ben Shum (bshum) wrote :

I think this was "public notes" under the unsponsored list of pending features for Tpac on the wiki. I've updated the page accordingly and linked to this bug ticket.

http://evergreen-ils.org/dokuwiki/doku.php?id=dev:opac:template-toolkit:plan

tags: added: tpac
Changed in evergreen:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Bill Erickson (berick) wrote :

Pushed a relatively simple version of the patron public notes to working => collab/berick/tpac-public-user-notes. The n display in the 'Account Summary' box on the first page of my-account.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/tpac-public-user-notes

tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.3.0-alpha
Changed in evergreen:
milestone: 2.3.0-alpha1 → 2.3.0-alpha2
Revision history for this message
Jason Stephenson (jstephenson) wrote :

signed off in collab/dyrcona/tpac-public-user-notes on the working repository.

Thanks, Bill!

tags: added: signedoff
Revision history for this message
Dan Scott (denials) wrote :

Hrm. It looks like the current CSS automatically converts all of the text to upper-case; that's not great. Also, the layout isn't particularly accessible; it's not clear that the table is a table of notes, or that the left table cell is a note title and the right table cell is note content. I'll give a shot at reformatting this somewhat.

Revision history for this message
Dan Scott (denials) wrote :

Pushed what seems to me to be a more accessible and cleaner layout to working/user/dbs/user_notes in an additional commit; this gives sites more control of the layout via the stylesheet.

Revision history for this message
Bill Erickson (berick) wrote :

Looks good to me. Pushed to master. Thanks, Dan.

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: Triaged → In Progress
status: In Progress → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.