UI for perm_list.html could be better

[Joseph]

Version: master

The perm_list.html interface displays two scrollbars, one outer for the whole page, and one inner for the grid. The outer could be removed if the save and delete buttons were placed on top with a toolbar along with the "add" button this would:

 - Reduce visual complexity
 - Reduce mistakes of which toolbar is chosen
 - Add horizontal space to the monitor (not that great of a boon, but may still be worthwhile)
 - Make those features of the page more discoverable

[Michael Peters (mrpeters)]

Took Joesph's idea and put it to use.

To <email address hidden>:working/Evergreen.git
 * [new branch] perm_list_html_display_mods -> user/mrpeters-isl/perm_list_html_display_mods
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrpeters-isl/perm_list_html_display_mods

[Lebbeous Fogle-Weekley (lebbeous)]

When I try Mike's version, it is an improvement over what was there before, for sure, although I note the horizontal scrollbar is always off the bottom of the screen until you have the grid scrolled completely down, and the down arrow button on the vertical scrollbar is obscured as well.

I struggle with getting the layout right with this Dojo stuff (to be fair, it's probably easier in current versions of Dojo) as much as anyone. I wonder if Joseph might not be able to suggest the right way to perfect that last little bit?

If Joseph doesn't weigh in, this might still be improvement enough to merge anyway.

[Joseph (joehms22)]

That looks similar to what I had in mind. However, I do have one note: by moving the delete people button up to the top you should also bring the JS that was within the button tags, as that associated the action with the button.

If the javascript depended on where it was in the page, things could get messy (I don't remember, but that may be why I passed over doing this) in all likelyhood it should be fine.

Other than that, a tool bar is an excellent way to handle single-line widgets, and it looks better (personal opinion) as it differentiates the actions from the content.

http://dojotoolkit.org/reference-guide/1.6/dijit/Toolbar.html

[Kathy Lussier (klussier)]

I looked at this interface in a recent version of master, and I don't see the two scrollbars anymore. Is it possible this was fixed with other code in the two years since the bug was originally reported?

Setting to incomplete for now. If I'm missing something and someone else is able to confirm that the problem still exists, feel free to set it back to confirmed.

[Galen Charlton (gmc)]

Removing the pullrequest and bitesize tags, given that it's been about a year and a half and nobody has reported an issue with the UI. Also, this will become moot with webstaff.