Using checkout, last activity shows as unset

Bug #1007020 reported by Ben Shum
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.2
Fix Released
Medium
Unassigned
2.3
Fix Released
Medium
Unassigned

Bug Description

Evergreen version: master

Using the Check Out interface to retrieve a patron via their barcode brings up the patron record with the last activity value showing as "unset" instead of the date and activity as expected. Using the patron search interface to retrieve the same records, the last activity date and action is set correctly.

tsbere noted in IRC that perhaps the interface doesn't know how to look up patrons via methods other than ID?

Revision history for this message
Michael Peters (mrpeters) wrote :

For what it's worth, I tested master (2506f44) with a test user, and a test checkout and was NEVER able to get "Last Activity" to populate. I then realized, "activity" means an OPAC login (maybe other things?) so I logged in with the test user and was able to duplicate Ben's initial report.

Search by ID works, search by barcode results in <Unset> as reported.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
tags: added: barcode bitesize id patron search staffclient
tags: added: activity last
Revision history for this message
Michael Peters (mrpeters) wrote :

Marking as bitesize since I think tsbere's thought that the API doesn't know how to handle a look-up by barcode is plausible.

I think starting in Open-ILS/xul/staff_client/server/patron/summary.js would be the way to go.

Revision history for this message
Mark Cooper (markchristophercooper) wrote :

Have the fix ... just need to sort out working repo access to make pull request.

Changed in evergreen:
assignee: nobody → Mark Cooper (markchristophercooper)
status: Confirmed → In Progress
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Cool! Thanks Mark. Tested and seems to be working for me. As a suggestion for next time, don't forget to add a link to where you end up pushing it to; though I did manage to find it in the working repo anyways :)

Sign-off: user/bshum/lp1007020

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1007020

Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master, rel_2_3, & rel_2_2. Thanks Mark!

Changed in evergreen:
assignee: Mark Cooper (markchristophercooper) → nobody
status: In Progress → Fix Committed
milestone: none → 2.4.0-alpha
Ben Shum (bshum)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.