tpac: Bookbag ID parameter breaks holds interface in my account

[Kathy Lussier]

Evergreen version: 2.2 RC1

After logging into tpac, a user takes the following steps:

1. Clicks on "My Account" and then goes to their lists page.

2. Clicks on the title for a particular list. The "id" parameter is added to the URL to identify which list should be viewed.

3. After viewing the list, if the user then clicks the "holds" tab, the id for the list is propagated in the URL, which leads to an internal server error. If you remove this parameter from the URL, everything displays normally.

The list id is also propagated when clicking other links (account preferences, items checked out, etc.), but it doesn't lead to any problems with viewing those interfaces. I don't think it's a bad idea for the parameter to propagate since it means the list will still be open if the user returns to the list page. However, the holds page does not like that parameter in the URL

[Lebbeous Fogle-Weekley (lebbeous)]

Marking this as High mainly because I'm pretty sure I can fix it by 2.2.0.

[Dan Scott (denials)]

"id" is probably an overly generic GET param to use, while we're at it. Maybe something more specific / less likely to clash if propagated, such as "bbid" or "bbagid" or "bbag"?

[Bill Erickson (berick)]

See also bug #1004604, which breaks the bookbag view in master.

[Bill Erickson (berick)]

Code pushed to working => collab/berick/lp1003087_bbag_id

I had to touch more code than anticipated, so extensive poking and prodding appreciated.

[Lebbeous Fogle-Weekley (lebbeous)]

I have poked and prodded, without finding fault. Thanks Dan and Bill! Pushed to master and rel_2_2.

Forgot the actual sign-off on the commit for master though. Doh!