Manage user's roles does not propagate

[Jay Scruton]

When managing users that have existing roles assigned (standard user, reporter, etc...), you click on a user to pull them to the top to be able to change or add new roles, all of the roles revert to "No Access". This requires the end user to re-set every role the user had for each project in order to be able to add or change a new one. We are using version 2.3.1

[Bryan Alsdorf (balsdorf)]

I am unable to re-produce this. What browser are you using and is it saving form data such as email / password?

I have noticed in the past that if a browser is saving a username / login for Eventum it can mess up the add / edit user orm.

[Vlad Safronov (vsafronov)]

I have the same issue after upgrading from 2.2 to 2.3.1.
Latest Firefox 12.0.

I don't think it is browser issue because html from code has no traces of the propagated default values.

[Marcin M (x-marcin)]

Sam situation here.

Problem is not HTML nor borwser.

It is in PHP code. Exactly in method:
getDetailsAssoc in lib/eventum/class.user.php

this piece of code (starts line 700):
 foreach ($res as $usr_id => &$row) {
                // FIXME: maybe PEAR has some "fill NULL" mode?
                if (!isset($row['usr_grp_id'])) {
                    $row['usr_grp_id'] = null;
                }

                $row['group'] = Group::getName($row['usr_grp_id']);
                //--------------------------------------------------------
                //here is the bug
                $roles = Project::getAssocList($usr_id, false, true);
                $row['projects'] = array_keys($roles);
                $row['roles'] = $roles;
            }

Should be replaced with:
 foreach ($res as &$row) {
                // FIXME: maybe PEAR has some "fill NULL" mode?
                if (!isset($row['usr_grp_id'])) {
                    $row['usr_grp_id'] = null;
                }

                $row['group'] = Group::getName($row['usr_grp_id']);
                //and now it is fixed!!!!!!!!!!!!!!!
                $roles = Project::getAssocList($row['usr_id'], false, true);
                $row['projects'] = array_keys($roles);
                $row['roles'] = $roles;
            }

$res array has wrong indexes.

Hope this helps.

[Elan Ruusamäe (glen666)]

this appears to be fixed via #727797 in
https://github.com/eventum/eventum/commit/4c67e2ded673f245afa5447d3691fe507f00f428