cronjobs erroneously report removed lock files
Bug #904033 reported by
Hartmut Holzgraefe
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Eventum |
Fix Released
|
Low
|
Elan Ruusamäe |
Bug Description
When starting the mail queue and download cronjobs with --fix-locks they will always print that they removed lock files even when no lock file existed at all.
When running this within a cron job an email report will always be triggered, i'd rather like to have a report sent to me only if there really was a stale lock file that needed to be removed.
Related branches
lp:~hartmut-php/eventum/bug904033
- Eventum Development Team: Pending requested
-
Diff: 76 lines (+15/-10)4 files modifiedcrons/check_reminders.php (+3/-2)
crons/download_emails.php (+6/-4)
crons/process_mail_queue.php (+3/-2)
lib/eventum/class.lock.php (+3/-2)
Changed in eventum: | |
milestone: | none → 2.3.3 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch fixes this by making Lock::release() return true if it actually removed a lock file, false otherwise and only printing "removed lock file" messages in the cron job scripts if true is returend from Lock::release()