Forms not update in general manage panel

[Quentin Estoppey]

The 4 new options for default notifications options cannot be update through mange/general.php page.
Please ass a test (isset) for the 4 new checkbox:
$setup["update"] = isset($_POST["update"]) ? $_POST["update"] : 0;
$setup["closed"] = isset($_POST["closed"]) ? $_POST["closed"] : 0;
$setup["emails"] = isset($_POST["emails"]) ? $_POST["emails"] : 0;
$setup["files"] = isset($_POST["files"]) ? $_POST["files"] : 0;

Otherwise ther is an empty error

[Quentin Estoppey (quentin-estoppey)]

Again I remember now that file notification.tpl.html doen't take in account the setup of thise options. If you set not notifications options by defaults (checkboxes unchecked in general manage panel), then the web interface still have the box checked by default.

To take in account the option setup, code should be like that (add of $default_actions.emails==1 condition in if):
<input type="checkbox" name="actions[]" {if ($info == '' && $default_actions.emails == 1) || $info.emails == 1}checked{/if} value="emails"> <a id="link" class="link" href="javascript:void(null);" onClick="toggleCheckbox('notification_form', 'actions[]', 0);">{t}Emails are Received or Sent{/t}</a><br />
            <input type="checkbox" name="actions[]" {if ($info == '' && $default_actions.updated == 1) || $info.updated == 1}checked{/if} value="updated"> <a id="link" class="link" href="javascript:void(null);" onClick="toggleCheckbox('notification_form', 'actions[]', 1);">{t}Overview or Details are Changed{/t}</a><br />
            <input type="checkbox" name="actions[]" {if ($info == '' && $default_actions.closed == 1) || $info.closed == 1}checked{/if} value="closed"> <a id="link" class="link" href="javascript:void(null);" onClick="toggleCheckbox('notification_form', 'actions[]', 2);">{t}Issue is Closed{/t}</a><br />
            <input type="checkbox" name="actions[]" {if ($info == '' && $default_actions.files == 1) || $info.files == 1}checked{/if} value="files"> <a id="link" class="link" href="javascript:void(null);" onClick="toggleCheckbox('notification_form', 'actions[]', 3);">{t}Files are Attached{/t}</a>

[Elan Ruusamäe (glen666)]

seems to be working in 2.4.0-pre1