External user on notification list copied on emails sent by them

[Cyrus Wadia]

Eventum v 2.3.3

If an external user on the notification list of an issue sends an email to that issue, it is copied back to them as well.
In eventum 2.1.1 they were excluded from the copy

Logic seems to have changed between 2.1.1 and 2.3.3 to allow for internal users to opt to get copies, but seems to have broken the logic for external users

class.notification.php at line 295

[Brian LaVallee (b-lavallee)]

// ==
//
// The v2.3.3 code was ONLY evaluating against Eventum Users.
// This is how I fixed the issue on my system.
//
if (!empty($email)) {
// don't send the email to the same person who sent it unless they want it

    if ($sender_usr_id != false) {
    // Check Eventum users preference
     $prefs = Prefs::get($sender_usr_id);
        if (!isset($prefs['receive_copy_of_own_action'][$prj_id])) {
         $prefs['receive_copy_of_own_action'][$prj_id] = 0;
        }
    }

    if (
 // Eventum User *OR* External Address
      (
      // Check Eventum User
       ($sender_usr_id != false) &&
          ($prefs['receive_copy_of_own_action'][$prj_id] == 0) &&
             (!empty($users[$i]["sub_usr_id"])) &&
             ($sender_usr_id == $users[$i]["sub_usr_id"])
            ) ||
            (
            // Check for External Addresses
             (strtolower(Mail_Helper::getEmailAddress($email)) == $sender_email)
            )
        ) {
   continue;
        }
    //}
     $emails[] = $email;
}

// ==

[Elan Ruusamäe (glen666)]

too old version