If program startup fails, player data are lost.

Bug #218799 reported by Edward Sheldrake
4
Affects Status Importance Assigned to Milestone
Extreme Tux Racer
Fix Committed
Medium
Paweł Drewniak

Bug Description

I upgraded to Fedora 9's mesa/Xserver, under which etracer will fail to start if the "stencil_buffer" option is true. I'm using the r300_dri driver.

Unfortunately, this caused all my high scores to be lost.

I had a quick look at the code, and the problem is that the highscores are saved in handle_system_error/winsys_exit, but they haven't been loaded yet if the failure is from winsys_init/setup_sdl_video_mode during program startup.

Revision history for this message
Paweł Drewniak (woody) wrote :

Confirming, it seems that the protection against this in highscore.cpp does not work. I'll fix it ASAP

Changed in etracer:
assignee: nobody → woodypl
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
Paweł Drewniak (woody) wrote :

Fixed as of SVN rev 103 - please test.

Changed in etracer:
status: In Progress → Fix Committed
Revision history for this message
Edward Sheldrake (ejs1920) wrote : It's player data not highscores

Sorry, I reported the bug wrong. The original protection in highscore.cpp works, highscores are not lost.

It's the best time, herring count and best score for each practice course that is lost, and also the status of each cup.

player.cpp needs protection similar to what is in highscore.cpp

Revision history for this message
Paweł Drewniak (woody) wrote : Re: If program startup fails, highscores are lost

Well, so that's strange, because I could confirm this highscore bug.... Nevermind, I'll implement the protection soon.

Changed in etracer:
status: Fix Committed → In Progress
Revision history for this message
Paweł Drewniak (woody) wrote :

Fixed as of rev 105.

Changed in etracer:
status: In Progress → Fix Committed
Revision history for this message
Edward Sheldrake (ejs1920) wrote :

Yes, confirmed. With rev 105, player data is not lost. Thanks!

Also, the stencil buffer bug which stopped etracer starting has been fixed in the Fedora 9 X server too.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.