epotes-client relies on /lib/lsb/init-functions, which may not provide the desired functionality in non-Debian-based distros

Bug #1226094 reported by Laércio de Sousa
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Epoptes
Fix Released
Medium
Alkis Georgopoulos

Bug Description

Current epoptes-client main script sources /lib/lsb/init-functions, which provide logging functions "log_begin_msg()" and "log_end_msg()" on Debian-based distros.

However, openSUSE 12.3's /lib/lsb/init-functions doesn't provide these functions. Instead, it provides "log_success_msg()", "log_warning_msg()" and "log_failure_msg()".

Moreover, it sources another openSUSE-specific config file named "/etc/rc.status", which exports LC_ALL=POSIX. This will set LC_ALL=POSIX in the environment of any command executed by Epoptes' execute dialog, which can lead to applications being opened in english, instead of user's default locale.

So, before sourcing /lib/lsb/init-functions, epoptes-client should check if distro is Debian-based (check for /etc/debian_version?). If sourcing /lib/lsb/init-functions is still desirable in openSUSE, please notice that

- the logging functions are different (see above),
- you should explicitly source file /etc/profile.d/lang.sh to get rid of LC_ALL, if its value is other than $LANG.

summary: - epotes-client relies in /lib/lsb/init-functions, which may not provide
+ epotes-client relies on /lib/lsb/init-functions, which may not provide
the desired functionality in non-Debian-based distros
description: updated
Fotis Tsamis (ftsamis)
Changed in epoptes:
assignee: nobody → Alkis Georgopoulos (alkisg)
Revision history for this message
cyberorg (jigish-gohil) wrote :

This still affects the client which does not have /lib/lsb/init-functions to server which has that file.

data/client-functions on the server sends log_end_msg to client which should just send echo "[ OK ]"

Revision history for this message
Alkis Georgopoulos (alkisg) wrote :
Changed in epoptes:
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

Fix released in epoptes 0.5.9.

Changed in epoptes:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.