RTEMS task var lock compromised in thread show function

[Jeff Hill]

I see that this code

void epicsThreadShow (epicsThreadId id, unsigned int level)
{
    struct taskVar *v;

    if (!id) {
        epicsThreadShowInfo (NULL, level);
        return;
    }
    taskVarLock ();
    for (v = taskVarHead ; v != NULL ; v = v->forw) {
        if ((rtems_id)id == v->id) {
            epicsThreadShowInfo (v, level);
            return;
        }
    }
    taskVarUnlock ();
    fprintf(epicsGetStdout(),"*** Thread %x does not exist.\n", (unsigned int)id);
}

needs a fix like this otherwise we can see (we have observed) a system lock up when epicsThreadShow is called on RTEMS

bzr diff src/libCom/osi/os/RTEMS/osdThread.c
=== modified file 'src/libCom/osi/os/RTEMS/osdThread.c'
--- src/libCom/osi/os/RTEMS/osdThread.c 2016-09-09 20:01:33 +0000
+++ src/libCom/osi/os/RTEMS/osdThread.c 2016-09-27 23:38:44 +0000
@@ -672,6 +672,7 @@
     for (v = taskVarHead ; v != NULL ; v = v->forw) {
         if ((rtems_id)id == v->id) {
             epicsThreadShowInfo (v, level);
+ taskVarUnlock ();
             return;
         }
     }

[mdavidsaver (mdavidsaver)]

Yup, looks like this has been broken for quite some time.

[mdavidsaver (mdavidsaver)]

Fixed on 3.14 http://bazaar.launchpad.net/~epics-core/epics-base/3.14/revision/12662