string substitution removes part of path when linking versioned shared libraries

[Jason Abernathy]

Hello!

I am building an EPICS extension which has the shared library version inside of it's directory name.

The full path is:

~/E-Linac/Packages/advsplugins-2.20120308

and the shared library version is 2:

SHRLIB_VERSION = 2

Once the versioned library was built the build system tried to create a symbolic link:

ln -s libNDPluginGeometricTransform.so.2 /home/jabrnthy/E-Linac/Packages/advsplugins-20120308/debian/tmp/usr/lib/linux-x86/libNDPluginGeometricTransform.so
ln: creating symbolic link `/home/jabrnthy/E-Linac/Packages/advsplugins-20120308/debian/tmp/usr/lib/linux-x86/libNDPluginGeometricTransform.so': No such file or directory

The error occurred because the linking command in RULES_BUILD removes all substrings of the form ".$(SHRLIB_VERSION)" which, in this case, also removes the ".2" from the directory name.

To fix this problem I changed the two linking commands in RULES_BUILD from

line 389: ln -s $< $(subst .$(SHRLIB_VERSION),,$@)
line 412: ln -s $< $(subst .$(LOADABLE_SHRLIB_VERSION),,$@)

to

line 389: ln -s $< $(@:.$(SHRLIB_VERSION)=)
line 412: ln -s $< $(@:.$(LOADABLE_SHRLIB_VERSION)=)

This is a greedier substitution which will only remove the last occurrence of the substring.

[Andrew Johnson (anj)]

Janet committed the fix, thanks Jason!

[Andrew Johnson (anj)]

Fix committed in 3.14.12.3 release.