RULES.db has incorrect dbExpand flags

Bug #861627 reported by Jason Abernathy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
EPICS Base
Fix Released
Undecided
Unassigned

Bug Description

Hello!

I believe that the two lines

INSTALL_DBDFLAGS += -I $(INSTALL_LOCATION)/dbd
INSTALL_DBFLAGS += -I $(INSTALL_LOCATION)/db

should be

INSTALL_DBDFLAGS += -I $(INSTALL_DBD)
INSTALL_DBFLAGS += -I $(INSTALL_DB)

to sync with any overrides.

Thanks

Revision history for this message
Andrew Johnson (anj) wrote :

Hi Jason,

Are you setting INSTALL_DBD and/or INSTALL_DB yourself without setting INSTALL_LOCATION? If you just set INSTALL_LOCATION the INSTALL_DBD and INSTALL_DB values will adjust automatically since they are what Make calls "recursively expanded" variables whose values are not computed until used.

I think your change is probably right (I'll check with Janet who maintains the build system), but if you're trying to alter the EPICS installation layout you'll have to make quite a few other incompatible changes elsewhere as well.

- Andrew

Andrew Johnson (anj)
Changed in epics-base:
status: New → Fix Committed
Revision history for this message
Jason Abernathy (j-abernathy) wrote :

Hi Andrew,

"Are you setting INSTALL_DBD and/or INSTALL_DB yourself without setting INSTALL_LOCATION?"

Nope! I'm setting them individually in a Debian packaging script:

INSTALL_LOCATION=$(CURDIR)/debian/tmp
INSTALL_LOCATION_BIN=$(INSTALL_LOCATION)/usr/bin
INSTALL_LOCATION_LIB=$(INSTALL_LOCATION)/usr/lib
INSTALL_HOST_BIN=$(INSTALL_LOCATION)/usr/bin
INSTALL_HOST_LIB=$(INSTALL_LOCATION)/usr/lib
INSTALL_INCLUDE = $(INSTALL_LOCATION)/usr/include/synapps
INSTALL_BIN = $(INSTALL_LOCATION)/usr/bin
INSTALL_LIB = $(INSTALL_LOCATION)/usr/lib
INSTALL_SHRLIB = $(INSTALL_LOCATION)/usr/lib/$(DEB_HOST_MULTIARCH)
INSTALL_DBD = $(INSTALL_LOCATION)/usr/share/epics/dbd
INSTALL_DB = $(INSTALL_LOCATION)/usr/share/epics/db

I noticed a problem when some support modules in synapps were unable to find their dbd files. After making the change it compiled with no problem.

I realize that I've removed the host and target architecture variables. This was just to make the packaging scripts simpler. If I ever compile for multiple target architectures then I'll have to re-add them. :)

Cheers,

- Jason

Andrew Johnson (anj)
Changed in epics-base:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.