TOP Env Var in envPaths doesn't match INSTALL_LOCATION

Bug #1165257 reported by Stephanie Allison on 2013-04-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
EPICS Base
Medium
Andrew Johnson

Bug Description

I'm working with epics 3.14.12.3 and have a comment about the TOP environment variable in the generated envPaths file under iocBoot/<ioc>.

When changing INSTALL_LOCATION in the ioc app's CONFIG_SITE to something other than TOP, I also (and always) have to change IOCS_APPL_TOP to be the same as INSTALL_LOCATION. (BTW, IOCS_APPL_TOP is not documented in the app dev guide but there are comments for it in the app's CONFIG_SITE though the link with INSTALL_LOCATION is not mentioned).

I have to do this since the ioc startup uses TOP from envPaths to position to the top of the installation (NOT the top of the place where the build was done).

Instead of changing both env vars in CONFIG_SITE, please change epics/base/configure/RULES.ioc to use INSTALL_LOCATION as TOP:

ifeq ($(IOCS_APPL_TOP),)
        $(PERL) $(TOOLS)/convertRelease.pl -a $(ARCH) -t $(INSTALL_LOCATION) $@
else
        $(PERL) $(TOOLS)/convertRelease.pl -a $(ARCH) -t $(IOCS_APPL_TOP) $@
endif

(Add the "-t $(INSTALL_LOCATION)").

Andrew Johnson (anj) wrote :

Hi Stephanie,

Thanks for the bug report. I am inclined to just initialize IOCS_APPL_TOP to $(INSTALL_LOCATION) by default, and remove the conditional completely, always using the 'else' half.

Please try the attached patch, which should fix this problem.

Thanks,

- Andrew

Changed in epics-base:
assignee: nobody → Andrew Johnson (anj)
importance: Undecided → Medium
status: New → In Progress

Hi Andrew,

Yes - this is a much better fix for envPaths creation - thank you.

Stephanie

> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Andrew
> Johnson
> Sent: Monday, April 08, 2013 8:54 AM
> To: Allison, Stephanie
> Subject: [Bug 1165257] Re: TOP Env Var in envPaths doesn't match
> INSTALL_LOCATION
>
> Hi Stephanie,
>
> Thanks for the bug report. I am inclined to just initialize
> IOCS_APPL_TOP to $(INSTALL_LOCATION) by default, and remove the
> conditional completely, always using the 'else' half.
>
> Please try the attached patch, which should fix this problem.
>
> Thanks,
>
> - Andrew
>
>
> ** Patch added: "iocApplTop.patch"
> https://bugs.launchpad.net/epics-
> base/+bug/1165257/+attachment/3631389/+files/iocApplTop.patch
>
> ** Changed in: epics-base
> Assignee: (unassigned) => Andrew Johnson (anj)
>
> ** Changed in: epics-base
> Importance: Undecided => Medium
>
> ** Changed in: epics-base
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1165257
>
> Title:
> TOP Env Var in envPaths doesn't match INSTALL_LOCATION
>
> Status in EPICS Base:
> In Progress
>
> Bug description:
> I'm working with epics 3.14.12.3 and have a comment about the TOP
> environment variable in the generated envPaths file under
> iocBoot/<ioc>.
>
> When changing INSTALL_LOCATION in the ioc app's CONFIG_SITE to
> something other than TOP, I also (and always) have to change
> IOCS_APPL_TOP to be the same as INSTALL_LOCATION. (BTW,
> IOCS_APPL_TOP
> is not documented in the app dev guide but there are comments for it
> in the app's CONFIG_SITE though the link with INSTALL_LOCATION is not
> mentioned).
>
> I have to do this since the ioc startup uses TOP from envPaths to
> position to the top of the installation (NOT the top of the place
> where the build was done).
>
> Instead of changing both env vars in CONFIG_SITE, please change
> epics/base/configure/RULES.ioc to use INSTALL_LOCATION as TOP:
>
> ifeq ($(IOCS_APPL_TOP),)
> $(PERL) $(TOOLS)/convertRelease.pl -a $(ARCH) -t $(INSTALL_LOCATION)
> $@
> else
> $(PERL) $(TOOLS)/convertRelease.pl -a $(ARCH) -t $(IOCS_APPL_TOP) $@
> endif
>
> (Add the "-t $(INSTALL_LOCATION)").
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/epics-base/+bug/1165257/+subscriptions

Andrew Johnson (anj) on 2013-04-09
Changed in epics-base:
status: In Progress → Fix Committed
Andrew Johnson (anj) on 2013-12-16
Changed in epics-base:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers