TODO: missing track tests
Bug #309235 reported by
Matt Layman
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Entertainer Media Center |
Fix Released
|
Medium
|
Matt Layman | ||
Bug Description
entertainerlib/
#TODO: write this test, how do you mock the LyricsDownloader that is
# interal to this function?
#TODO: write this test
Unimplemented tests.
testTrackFe
testTrackFe
Related branches
| Changed in entertainer: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
Revision history for this message
| Matt Layman (mblayman) wrote | #1 |
| Changed in entertainer: | |
| assignee: | nobody → laymansterms |
| milestone: | none → entertainer-0.3 |
| status: | Triaged → In Progress |
| Changed in entertainer: | |
| status: | In Progress → Fix Committed |
| Changed in entertainer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The Track object is exhibiting bad behavior. Track should not have its own internal LyricsDownloader to find lyrics. Because the LyricsDownloader is part of the Track object, that is what makes it so hard to test. Track will change with the new backend (eventually) and the object will be more sane. We'll need to decouple the LyricsDownloader and Track, but for now the unimplemented tests can be removed.