Picture section warning message and text overlap

Bug #235372 reported by Matt Layman
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Fix Released
Medium
Matt Layman

Bug Description

When a user has no picture directories set, the warning message and text that appear overlap each other.

Matt Layman (mblayman)
Changed in entertainer:
importance: Undecided → Low
Paul Hummer (rockstar)
Changed in entertainer:
importance: Low → Medium
status: New → Triaged
Revision history for this message
Charclo (charclo-michael) wrote :

I have already fixed this in my branch. I'll commit it later

Revision history for this message
Jamie Bennett (jamiebennett) wrote :

Changing this to 'Fix Committed' as Charclo has indicated he has fixed it. Charclo, please propose your fix for merging into the main branch.

Changed in entertainer:
status: Triaged → Fix Committed
Paul Hummer (rockstar)
Changed in entertainer:
milestone: none → 0.1-release
Revision history for this message
Charclo (charclo-michael) wrote :

Ok I fixed this, I also noticed that the text that is displayed isn't correct anymore.
It says "There are no indexed photographs in the Entertainer media library. To add photographs, click on 'content' button on toolbar and open 'images' tab. Now click on 'add' button and select some folders which contains image files." and "To use headlines you have to add some RSS feeds with content management tool. To do this, click 'Content' button located in toolbar. Select 'RSS feeds' tab and click 'Add' button. Now you can write RSS feed URL to textentry. You can get RSS feed URL from webpages that support RSS."
Should these texts - temporarily - be changed?

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Yeah they should, you could say "Open the Content Manager Tool" instead of "Click 'Content' button located in toolbar"

Revision history for this message
Charclo (charclo-michael) wrote :

The text doesn't overlap anymore in my branch. It's ready for merging

Changed in entertainer:
status: Fix Committed → In Progress
Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Bugfix branch merged into trunk

Changed in entertainer:
status: In Progress → Fix Committed
Changed in entertainer:
assignee: nobody → charclo-michael
Revision history for this message
Charclo (charclo-michael) wrote :

Because of some pylint fixes, this bug was reintroduced, rev 225 in photoalbums_screen.py @@ -121,28 +114,34 @@ and rss_screen.py @@ -218,20 +219,28 @@.

Changed in entertainer:
assignee: charclo-michael → nobody
status: Fix Committed → Triaged
Revision history for this message
Matt Layman (mblayman) wrote :

Since it was my pylint work that wiped out charclo's fixes (not sure how that happened, I guess one of us didn't merge from the other, who knows), I'll replicate charclo's work from a new branch to fix the problem.

Changed in entertainer:
assignee: nobody → laymansterms
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in entertainer:
status: In Progress → Fix Committed
Revision history for this message
Matt Layman (mblayman) wrote :
Changed in entertainer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.