Lyrics fetching blocks UI

[Jamie Bennett]

Reported by charclo.michael, Apr 11, 2008

What steps will reproduce the problem?
1. Play a song
2. See the progress bar window
3. Screen freezes after 2 seconds

What is the expected output? What do you see instead?
-The regular window with the progress bar
-Frozen window

What version of the product are you using? On what operating system?
rev255 on ubuntu

Please provide any additional information below.
This will probably only happen when leoslyrics.com is really slow. When I
go to the site right now it takes 10 seconds to load.

[Jamie Bennett (jamiebennett)]

** IMPORTED FROM GOOGLE CODE **

[Joshua Scotton (joshuascotton)]

Lyrics fetching needs to be threaded and have a timeout.
If that has been done in Charclo's changes can we mark this as done?

[Charclo (charclo-michael)]

I added a timeout of 5 seconds for fetching the url in my code. gobject timeout is also used with a callback but it doesn't seem to be working correctly so this bug can't be closed yet.

[Paul Hummer (rockstar)]

Adding the timeout the request is already added in charclo's branch, so if it takes too long, it times and and moves on (thus not giving you lyrics, but not blocking for too long). It's a fair workaround, and so this can be moved off the 0.1 release.

[Jamie Bennett (jamiebennett)]

Is it a complete workaround or is a more elegant solution required?

[Matt Layman (mblayman)]

The lyrics tab isn't using gobject timeout's at all. I think that this should be fairly easy to fix.

[Matt Layman (mblayman)]

I've not actually been working on this. I gave a quick stab at it a while ago, but it didn't work. I didn't do any further investigation and I haven't picked this back up.