New weather module

[Jamie Bennett]

** IMPORTED FROM GOOGLE CODE **

Reported by xanium4332, Feb 09, 2008

Create a weather module, allowing local weather information to be
easily/quickly accessed in a nice interface.

Comment 1 by laymansterms.dev, Mar 06, 2008

(No comment was entered for this change.)

Status: Started
Owner: laymansterms.dev
Comment 2 by laymansterms.dev, Mar 08, 2008

(No comment was entered for this change.)

Status: Accepted
Owner: joshuascotton
Comment 3 by joshuascotton, Mar 08, 2008

Added Weather and WeatherForecast classes to utils.weather
Need to work on the frontend and also create a configuration tool in content manager

Status: Started

[Matt Layman (mblayman)]

Migrating info over from Google Code.

[Jamie Bennett (jamiebennett)]

======================================================================
FAIL: testWeatherSearch (Weather_test.WeatherTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jamie/develop/bug-224691/src/tests/Weather_test.py", line 49, in testWeatherSearch
    self.assertEqual(self.weather.search("derby"),[("UKXX0040","Europe > United Kingdom > Derby")])
AssertionError: [] != [('UKXX0040', 'Europe > United Kingdom > Derby')]

[John (jc453)]

Attempting the same tests in a console reveal the problem to be here:

 def search(self, search_string):
        """
        Searchs Yahoo for location in search_string and returns list of tuples
        @param search_string String
        @return list(tuple(location_id String, PlaceName String))
        """
        response = self.find_weather_search_results_page(search_string)

        if response.status == 302:
            redirect_url = response.getheader('location', '')
            the_code = redirect_url[10:len(redirect_url)-5]

            the_placename = self.get_location_from_id(the_code)

            return [(the_code, the_placename)]
        else:
            return []

The actual response.status is 301, although simply changing the if statement to 301 does not fix it. I did not investigate it further.

[Jamie Bennett (jamiebennett)]

I'll take a look at this.

[Joshua Scotton (joshuascotton)]

Jamie, your branch has been merged, can this be marked as 'Fix Committed' now?

[Paul Hummer (rockstar)]

No, this branch cannot be marked 'Fix Committed' until the images for weather have landed, and they hadn't yet. I merged in Jamie's branch but it's not the complete feature yet.

[Joshua Scotton (joshuascotton)]

Jamie, I downloaded your branch and ran the tests, I got three failures which were down to this:

in theme.py on line 106 change
        self.image['weather-cloudy'] = os.path.join(img_path, "weather/clouds.png")
to
        self.image['weather-clouds'] = os.path.join(img_path, "weather/clouds.png")

I did that in my local copy and it fixed the tests

[Matt Layman (mblayman)]

Released and available at http://www.entertainer-project.com/download.php