Periodic pinger plugin fails after XMPP connection flap
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
EnDroid |
Fix Released
|
Critical
|
Phil Connell |
Bug Description
Some unreliability in periodic pinger:
- If endroid's connection to its XMPP server is lost, a *lot* of ping failures are reported (logging changed to report errors at ERROR level rather than DEBUG).
- Afterwards, an internal failure is hit in twisted (and unhandled by periodic pinger)
- This kills the LoopingCall, meaning no further pings are sent
00:17:08 endroid.
00:17:18 endroid.
00:17:28 endroid.
00:17:38 endroid.
00:17:48 endroid.
00:17:58 endroid.
00:17:58 root ERROR Failed to ping gmail.com: Connection to the other side was lost in a non-clean fashion.
00:17:58 root ERROR Failed to ping redacted.com: Connection to the other side was lost in a non-clean fashion.
00:17:58 root ERROR Failed to ping gmail.com: Connection to the other side was lost in a non-clean fashion.
00:17:58 root ERROR Failed to ping redacted.com: Connection to the other side was lost in a non-clean fashion.
[many identical logs]
00:17:58 root ERROR Failed to ping gmail.com: Connection to the other side was lost in a non-clean fashion.
00:17:58 root ERROR Failed to ping redacted.com: Connection to the other side was lost in a non-clean fashion.
00:17:58 root WARNING Lost connection to XMPP
00:18:08 endroid.
Unhandled error in Deferred:
Unhandled Error
Traceback (most recent call last):
File "/home/
self.mainLoop()
File "/home/
self.
File "/home/
call.
File "/home/
d = defer.maybeDefe
--- <exception caught here> ---
File "/home/
result = f(*args, **kw)
File "/home/
d = self.usermanage
File "/home/
return self._ping_
File "/home/
File "/home/
upgradeWith
File "/home/
xs.iqDeferreds = {}
exceptions.
00:19:29 root INFO Connected to XMPP
00:19:29 root INFO Initialised group all
Related branches
- Phil Connell: Approve
-
Diff: 88 lines (+28/-11)4 files modifieddebian/changelog (+8/-0)
etc/init/endroid.conf (+1/-1)
setup.py (+1/-1)
src/endroid/plugins/periodicpinger.py (+18/-9)
Changed in endroid: | |
status: | New → In Progress |
assignee: | nobody → Phil Connell (pconnell) |
Changed in endroid: | |
status: | In Progress → Fix Released |