TODO wait for database recovery on EPBXT initialization

Bug #527899 reported by Martin Scholl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
embedded PBXT
Medium
Martin Scholl

Bug Description

Do a blocking wait for database recovery upon EPBXT initialization in EPBXT::init_epbxt()

Related branches

Martin Scholl (ms-fk)
Changed in embedded-pbxt:
milestone: none → m02
assignee: nobody → Martin Scholl (ms-fk)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Martin,

There is probably no need to do async recovery in EPBXT.

Just call the following:

 xt_open_database(self, mysql_real_data_home, TRUE);
 pbxt_database = self->st_database;
 xt_heap_reference(self, pbxt_database);

instead of xt_xres_start_database_recovery().

The only reason this is done asynchronously is to work around problems in MySQL. Namely: the MySQL plugin environment is not completely initialized and creation of a THD can fail.

Revision history for this message
Martin Scholl (ms-fk) wrote : Re: [Bug 527899] Re: TODO wait for database recovery on EPBXT initialization

Hello Paul,

there is already a commit where I simply call
xn_xres_run_recovery_thread in the pbxt initialization function; that
looks like an unclean solution in the light of your proposal.

The recovery thread in xn_xres_run_recovery_thread waits for the
sweeper to terminate before returning. Should I add this too?

Martin

On Thu, Feb 25, 2010 at 7:29 PM, Paul McCullagh
<email address hidden> wrote:
> Hi Martin,
>
> There is probably no need to do async recovery in EPBXT.
>
> Just call the following:
>
>        xt_open_database(self, mysql_real_data_home, TRUE);
>        pbxt_database = self->st_database;
>        xt_heap_reference(self, pbxt_database);
>
> instead of xt_xres_start_database_recovery().
>
> The only reason this is done asynchronously is to work around problems
> in MySQL. Namely: the MySQL plugin environment is not completely
> initialized and creation of a THD can fail.
>
> --
> TODO wait for database recovery on EPBXT initialization
> https://bugs.launchpad.net/bugs/527899
> You received this bug notification because you are a direct subscriber
> of the bug.
>

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote : Re: [Bug 527899] Re: TODO wait for database recovery on EPBXT initialization

Yes, that needs to be added as well.

On Feb 25, 2010, at 7:55 PM, Martin Scholl wrote:

> Hello Paul,
>
>
> there is already a commit where I simply call
> xn_xres_run_recovery_thread in the pbxt initialization function; that
> looks like an unclean solution in the light of your proposal.
>
> The recovery thread in xn_xres_run_recovery_thread waits for the
> sweeper to terminate before returning. Should I add this too?
>
>
> Martin
>
>
> On Thu, Feb 25, 2010 at 7:29 PM, Paul McCullagh
> <email address hidden> wrote:
>> Hi Martin,
>>
>> There is probably no need to do async recovery in EPBXT.
>>
>> Just call the following:
>>
>> xt_open_database(self, mysql_real_data_home, TRUE);
>> pbxt_database = self->st_database;
>> xt_heap_reference(self, pbxt_database);
>>
>> instead of xt_xres_start_database_recovery().
>>
>> The only reason this is done asynchronously is to work around
>> problems
>> in MySQL. Namely: the MySQL plugin environment is not completely
>> initialized and creation of a THD can fail.
>>
>> --
>> TODO wait for database recovery on EPBXT initialization
>> https://bugs.launchpad.net/bugs/527899
>> You received this bug notification because you are a direct
>> subscriber
>> of the bug.
>>
>
> --
> TODO wait for database recovery on EPBXT initialization
> https://bugs.launchpad.net/bugs/527899
> You received this bug notification because you are subscribed to
> embedded PBXT.
>
> Status in Embedded PBXT (EPBXT): In Progress
>
> Bug description:
> Do a blocking wait for database recovery upon EPBXT initialization
> in EPBXT::init_epbxt()
>
>

--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com

Martin Scholl (ms-fk)
Changed in embedded-pbxt:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers