Improve Noise's sound menu integration

[Mario Guerriero]

Noise should have its entry in the Music Menu

[Eduard Gotwig (gotwig)]

It has its entry in the Music Menu, if you start it once. More information needed.

[Mario Guerriero (mefrio-g)]

No other information. If I open the Music Menu I can see Rhythmbox, Banshee but not Noise, that's all

[Brendan William (bwilliam)]

oneiric?

[Victor Martinez (victored)]

You have to run noise at least once for it to apear in the sound menu, although I agree that it should be there from the start. In that case you may want to target the bug at elementaryOS. I wonder what Ubuntu does with Rhythmbox (I hope they're not hardcoding it inside indicator-sound-menu.)

[Mario Guerriero (mefrio-g)]

I use Noise as my default player so I run it every time I use the pc but it is probably only a bug of my machine

[Victor Martinez (victored)]

If that's the case I'll mark it as incomplete until we figure out what's wrong. If you're using Oneiric, it's a known bug and we shouldn't be doing anything about it.

[Mario Guerriero (mefrio-g)]

No I use Precise

Mario Guerriero
Sent from iPhone 3GS

Il giorno 05/mag/2012, alle ore 23:41, Victor Eduardo <email address hidden> ha scritto:

> If that's the case I'll mark it as incomplete until we figure out what's
> wrong. If you're using Oneiric, it's a known bug and we shouldn't be
> doing anything about it.
>
> ** Changed in: noise
> Status: Invalid => Incomplete
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/995060
>
> Title:
> Music Menu support
>
> Status in Noise Audio Player:
> Incomplete
>
> Bug description:
> Noise should have its entry in the Music Menu
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/noise/+bug/995060/+subscriptions

[Victor Martinez (victored)]

I investigated more about this issue and found that Rhythmbox's desktop-file name is hardcoded in indicator-sound, and that's why it appears to be always active. It is also present in the GSettings schema by default.

I've started working on that indicator to achieve the same with Noise. It works. I'm pushing it to lp:~victored/+junk/elementary-sound-menu

[Sergey "Shnatsel" Davidoff (shnatsel)]

Victor: please make a branch based on lp:~elementary-os/ubuntu-package-imports/indicator-sound-precise

[Sergey "Shnatsel" Davidoff (shnatsel)]

And I can alter GSettings defaults if needed.

[Victor Martinez (victored)]

Sergey: I'll do, thanks.

[Victor Martinez (victored)]

A fix has been committed to lp:~victored/elementaryos/indicator-sound

Commit message:

    Allow setting preferred media players through a settings key instead of hardcoding them.

    Originally this was done by hardcoding "rhythmbox.desktop" in PlayerController.vala. Now it's possible to set the list of preferred players by modifying the "preferred-media-players" key located at com.canonical.indicator.sound.* Modifications to that key are applied at run-time and it's always monitored. Of course this setting key only applies to non-blacklisted players.

    Currently, setting a player as "preferred" only makes its controls visible all the time.

    Also added BeatBox and Noise to the "interested-media-players" and "preferred-media-players" keys, and removed "rhythmbox" from the latter.

[Sergey "Shnatsel" Davidoff (shnatsel)]

Victor, would you propose your fixes upstream? That seems to be an upstreamable change and that would free you from the burden of maintaining the patch.

[Victor Martinez (victored)]

Yes, I was thinking the same. I will make a separate branch from the last revision and propose it upstream.

[Victor Martinez (victored)]

My fixes were merged upstream. See https://bugs.launchpad.net/indicator-sound/+bug/1014955

[Pranav (pranavkaranjkar)]

 I am having trouble with its music menu integration in the daily build of luna. Noise shows up in the music menu and until few days ago, everything was working as it was supposed to, but now out of sudden the musicmenu controls for noise doesn't seem to do anything..

[Pranav (pranavkaranjkar)]

Also stopped getting notifications for noise.. Is there a way I can restore all the noise settings systemwide to see if it is a problem with my installation?