Comment 4 for bug 264071

Revision history for this message
Martin Pitt (pitti) wrote :

Some issues:
 - why does the patch move around the Symlink() function? That's confusing and unnecessary IMHO. If you need it earlier, maybe just add a prototype?
 - calloc/strcat/strcat could be replaced with a single asprintf() to improve readability and robustness
 - resolving symlinks should be done with realpath(3), instead of doing a loop all by yourself
 - can you please report this to upstream?