Use CSD Titlebar
Bug #1288048 reported by
Danielle Foré
This bug affects 7 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Audience |
Fix Released
|
Wishlist
|
Danielle Foré | ||
Eidete |
Fix Released
|
Wishlist
|
Fabio Zaramella | ||
Terminal |
Fix Released
|
Low
|
Danielle Foré |
Bug Description
as of gtk 3.11.8 dialogs are now using CSD Titlebars. Not headerbar, but titlebar. This must be available to regular apps.
We should investigate and look into implementing CSD Titlebar since it doesn't come with the padding/style associated with headerbar.
Related branches
lp:~elementary-apps/pantheon-terminal/csd-titlebar
- Victor Martinez (community): Approve
- Danielle Foré: Abstain
-
Diff: 24 lines (+8/-1)1 file modifiedsrc/PantheonTerminalWindow.vala (+8/-1)
lp:~elementary-apps/audience/headerbar
- Corentin Noël: Approve
- Victor Martinez (community): Approve
-
Diff: 16 lines (+6/-0)1 file modifiedsrc/Audience.vala (+6/-0)
lp:~fabiozaramella/eidete/eidete
- Cody Garver: Pending requested
-
Diff: 59 lines (+10/-6)2 files modifiedCMakeLists.txt (+2/-2)
src/eidete.vala (+8/-4)
lp:~audience-members/audience/gtk-3.12
- Cody Garver: Needs Fixing
- Robert Roth (community): Abstain
-
Diff: 4734 lines (+1792/-2173)27 files modifiedCMakeLists.txt (+3/-59)
cmake/FindGirCompiler.cmake (+56/-0)
cmake/GObjectIntrospectionMacros.cmake (+34/-0)
cmake/Makefile (+0/-286)
cmake/Translations.cmake (+37/-12)
cmake/ValaPrecompile.cmake (+75/-12)
data/CMakeLists.txt (+12/-0)
data/org.pantheon.audience.gschema.xml (+10/-5)
src/Audience.vala (+467/-473)
src/CMakeLists.txt (+57/-0)
src/Consts.vala (+3/-2)
src/DiskManager.vala (+98/-0)
src/Settings.vala (+35/-18)
src/Utils.vala (+56/-202)
src/Widgets/BottomBar.vala (+160/-0)
src/Widgets/Button.vala (+0/-53)
src/Widgets/ControlsBar.vala (+0/-137)
src/Widgets/LLabel.vala (+0/-27)
src/Widgets/MediaSlider.vala (+0/-238)
src/Widgets/Playlist.vala (+92/-57)
src/Widgets/PlaylistPopover.vala (+116/-0)
src/Widgets/PreviewPopover.vala (+90/-0)
src/Widgets/SettingsPopover.vala (+166/-0)
src/Widgets/TagView.vala (+0/-253)
src/Widgets/TimeWidget.vala (+127/-0)
src/Widgets/TopPanel.vala (+0/-87)
src/Widgets/VideoPlayer.vala (+98/-252)
Changed in audience: | |
importance: | Undecided → Wishlist |
milestone: | none → isis-beta1 |
status: | New → Confirmed |
Changed in audience: | |
milestone: | isis-beta1 → isis-beta2 |
Changed in pantheon-terminal: | |
status: | Confirmed → In Progress |
assignee: | nobody → Daniel Fore (danrabbit) |
milestone: | none → isis-beta1 |
Changed in pantheon-terminal: | |
status: | In Progress → Fix Committed |
Changed in pantheon-terminal: | |
status: | Fix Committed → Fix Released |
Changed in audience: | |
status: | Confirmed → In Progress |
Changed in audience: | |
status: | In Progress → New |
Changed in audience: | |
status: | New → In Progress |
assignee: | nobody → Daniel Fore (danrabbit) |
Changed in eidete: | |
status: | New → In Progress |
assignee: | nobody → Fabio Zaramella (ffabio-96-x) |
Changed in eidete: | |
importance: | Undecided → Wishlist |
Changed in audience: | |
assignee: | Daniel Fore (danrabbit) → Fabio Zaramella (ffabio-96-x) |
Changed in audience: | |
assignee: | Fabio Zaramella (ffabio-96-x) → nobody |
Changed in audience: | |
assignee: | nobody → Daniel Fore (danrabbit) |
Changed in audience: | |
milestone: | freya-beta2 → freya-beta1 |
Changed in audience: | |
status: | In Progress → Fix Committed |
Changed in eidete: | |
status: | In Progress → Fix Released |
no longer affects: | midori |
Changed in audience: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Adding Midori just so Christian has the option to decide whether to go full headerbar or just titlebar