Provide :focus state for buttons

Bug #987526 reported by Danielle Foré
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
elementary Stylesheet
Fix Released
Undecided
Cassidy James Blaede

Bug Description

What it says on the tin

We also need to take into account "help" and "noundo" buttons

Tags: focus
Changed in egtk:
milestone: none → 3.2
Changed in egtk:
milestone: 3.2 → 3.3
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Help, noundo, and the light decorated windows, yeah?

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Also, infobars?

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

And then there are things like check boxes, radios, inputs...

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Okay, going to file separate bugs for each instance. I'm working on normal buttons right now. :)

Revision history for this message
David Hsu (illusionmist62442) wrote :

Since this is In Progress I'll just mention it here rather than filing a bug:

The focus ring should not apply to active (in pressed state) button.
I think 'active' is 'focus' enough, besides the ring looks kinda weird around pressed buttons and blurs the crisp border.
Otherwise you may want to improve the ring style with active buttons if it's gonna stay.

Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm going to mark this bug as fixed since (regular) buttons do have focus states. We should file separate reports for the .content-view, .no-undo, etc buttons.

Changed in egtk:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in egtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.