ecryptfs warns about undefined salt in ecryptfsrc - bug + solution

Bug #372709 reported by David Hicks
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fix Released
Dustin Kirkland 

Bug Description

ecryptfs puts the following warning in a variety of logfiles and on the command line e.g. when using ecryptfs-add-passphrase -

Warning: Using default salt value (undefined in ~/.ecryptfsrc)

I started investigating and found that pretty much whatever I put in the rc file the same message came out. So I grabbed the source and started poking around. After a while I found that in the file key_management.c there is a problem (on lines 718/9 in version 68 that I'm using):

if (valsize != ECRYPTFS_SALT_SIZE_HEX);
 goto next_iteration;

That semi-colon at the end of the if statement means that the goto is always called, and any salt value placed in ~/.ecryptfsrc will always be ignored, and the warning will always be shown. This bug is still present in the latest version of the source file.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :


Thanks so much for the bug report and analysis. That's a nasty one. I have committed the fix. It will be in the -76 release.


Changed in ecryptfs:
assignee: nobody → Dustin Kirkland (kirkland)
importance: Undecided → High
milestone: none → 76
status: New → Fix Committed
Changed in ecryptfs:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.