| 2017-06-05 05:51:01 |
Jason Xing |
description |
Reproduce case:
1) User doesn't install openssl.
2) Run ecryptfs-manager and make selection 3.
It goes in the dead loop...which means whatever selection you choose cannot end this command or alter your option.
Details in code:
Please look at src/libecryptfs/decision_graph.c From line 558 ti line 597 (see http://bazaar.launchpad.net/~ecryptfs/ecryptfs/trunk/view/head:/src/libecryptfs/decision_graph.c#L558):
It will prompt user to enter the selection which is set to "val" variable and then run into "else" portion instead of "if" portion. However, "node->num_transitions" which was set to zero before causes the terrible result (dead loop): it will skip for loop and test if the "valid_val" is 0. If not, go back to get_value part (line 558) and do it one more time.
Reason:
1) User doesn't install openssl module.
2) The developers of ecryptfs-manager doesn't take such case into consideration.
Quote from Tyler (see https://bugs.launchpad.net/ecryptfs/+bug/878239/comments/3):
"> Option 3 allows to generate a new public/private key pair, but asks for
> a key type without giving the slightest hint about what type choices
> there are.
That's because you don't have the OpenSSL key module installed. The
ecryptfs-manager prompts should take this into account, but they don't.
Please consider filing a separate bug about this."
Because of that, I'm opening this bug report! |
Reproduce case:
1) User doesn't install openssl.
2) Run ecryptfs-manager and make selection 3.
It goes in the infinite loop...which means whatever selection you choose cannot end this command or alter your option.
Details in code:
Please look at src/libecryptfs/decision_graph.c From line 558 ti line 597 (see http://bazaar.launchpad.net/~ecryptfs/ecryptfs/trunk/view/head:/src/libecryptfs/decision_graph.c#L558):
It will prompt user to enter the selection which is set to "val" variable and then run into "else" portion instead of "if" portion. However, "node->num_transitions" which was set to zero before causes the terrible result (infinite loop): it will skip for loop and test if the "valid_val" is 0. If not, go back to get_value part (line 558) and do it one more time.
Reason:
1) User doesn't install openssl module.
2) The developers of ecryptfs-manager doesn't take such case into consideration.
Quote from Tyler (see https://bugs.launchpad.net/ecryptfs/+bug/878239/comments/3):
"> Option 3 allows to generate a new public/private key pair, but asks for
> a key type without giving the slightest hint about what type choices
> there are.
That's because you don't have the OpenSSL key module installed. The
ecryptfs-manager prompts should take this into account, but they don't.
Please consider filing a separate bug about this."
Because of that, I'm opening this bug report! |
|
