Cannot mount with the passphrase containing '=' character

[Jason Xing]

Hello,

I'm here opening an existing bug report(also, see bug #1419861) because there're other situations that cause such errors ----we could not mount with the passphrase to parse/file to read containing '=' character.
1) case 1:
$sudo mount -t ecryptfs raw secure -o passwd=123=abc
I'm trying use the passphrase which is "123=abc" and it will go wrong.

2) case 2;
There is a file named <key> whose content is "passwd=123=abc" and we mount as following:
$sudo mount -t ecryptfs raw secure -o passphrase_passwd_file=key
It will also go wrong.

3) case 3:
I created a file named <k=ey> whose content is "passwd=123=abc" and we mount as following:
$sudo mount -t ecryptfs raw secure -o passphrase_passwd_file=k=ey
It will go wrong without any doubt.

I've fixed this issue by adding two lines in proccess_comma_tok() function in cmd_in_parser.c to jump the "for" loop.See my patch.

If there're still some problems you have, please let me know. Thank you.

Jason

[Jason Xing (wlxing)]

Did someone see this bug report and relating patch? Do you all need more information like reproduce case and test case?

Thanks for any comments!

[Jason Xing (wlxing)]

This bug has been fixed I think and I proposed the 2-line patch to be reviewed by eCryptfs developers.

If someone could review that, I would appreciate that...

[Tyler Hicks (tyhicks)]

Applied to lp:ecryptfs as r886