Passthru sample adapter calls vbStopMaking improperly

Bug #1781734 reported by Mark
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
eCAP
New
Undecided
Unassigned

Bug Description

I don't believe this problem exists in other adapters, but modifying adapter should be checked (it also calls vbStopMaking).

Calling vbStopMaking from noteVbContentDone is incorrect, as the adapted_body_content method may still be called by the host. The call should probably be moved to abStopMaking.

Not doing so triggers an exception in Squid, though it is currently silently ignored, because the virgin body has been discarded before its attempted retrieval (https://github.com/squid-cache/squid/blob/1c8fc2a269c1b2eaed1dc6a43dde1e2e66cca182/src/adaptation/ecap/XactionRep.cc#L553).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.