ec2-api fails when calling security_groups methods from novaclient after novaclient 8.0.0

[Alfredo Moralejo]

python-novaclient has removed the deprecated security_group APIs in https://review.openstack.org/447707 which is included in tag 8.0.0. ec2-api uses it so tempest tests are failing after tag 8.0.0 has been included in upper-constraints with errors like:

May 17 04:15:39.044164 ubuntu-xenial-osic-cloud1-s3500-8847648 ec2-api[26338]: 2017-05-17 04:15:39.042 27091 ERROR ec2api.api File "/opt/stack/new/ec2-api/ec2api/api/security_group.py", line 94, in _create_security_group
May 17 04:15:39.044238 ubuntu-xenial-osic-cloud1-s3500-8847648 ec2-api[26338]: 2017-05-17 04:15:39.042 27091 ERROR ec2api.api os_security_group = nova.security_groups.create(group_name,
May 17 04:15:39.044330 ubuntu-xenial-osic-cloud1-s3500-8847648 ec2-api[26338]: 2017-05-17 04:15:39.042 27091 ERROR ec2api.api AttributeError: 'Client' object has no attribute 'security_groups'
May 17 04:15:39.044436 ubuntu-xenial-osic-cloud1-s3500-8847648 ec2-api[26338]: 2017-05-17 04:15:39.042 27091 ERROR ec2api.api

These errors apear both in gate jobs [1] and in tests on RDO Trunk repos [2]

[1] http://logs.openstack.org/37/465237/1/check/gate-functional-neutron-dsvm-ec2api-ubuntu-xenial/d3f3ab4/logs/screen-ec2-api.txt.gz#_May_17_04_15_39_044330
[2] https://logs.rdoproject.org/weirdo-generic-puppet-openstack-scenario002/1658/weirdo-project/logs/ec2api/ec2api.txt.gz

[Andrey Pavlov (apavlov-e)]

is it only for master?

[Alfredo Moralejo (amoralej)]

yes, AFAIK, change in novaclient will not be backported to previous releases, so i guess it will only impact master.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466115
Committed: https://git.openstack.org/cgit/openstack/ec2-api/commit/?id=20f65fac2d71121c07b8e9d6b6153954e5e3aa74
Submitter: Jenkins
Branch: master

commit 20f65fac2d71121c07b8e9d6b6153954e5e3aa74
Author: tikitavi <email address hidden>
Date: Fri May 19 00:59:26 2017 +0300

    fix ec2-api after deprecation of nova-network functions in novaclient

    removed NovaEngine in addresses, availability_zones, instances, security_groups
    removed unit tests for NovaEngine
    disabled some unit tests using NovaEngine for further reworking

    Closes-bug: #1691484
    Change-Id: I662d5b57b9e46be80c1d2093038ada83897565eb

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ec2-api 7.0.0 release.