Silent failure if no bzrdefaults file

Bug #1831915 reported by Robert Ladyman on 2019-06-06
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
EasyBreezy
High
HBCoders

Bug Description

If the bzrdefaults file does not exist, then operations depending upon it that cannot use existing settings (checkout, new project) silently fail.
The action should probably report that the settings file is either missing or has no values set.

Rory Ladyman (rwbl) on 2019-06-11
tags: added: error-reporting
tags: added: ui
Changed in easybreezy:
status: New → Triaged
status: Triaged → New
status: New → Triaged
importance: Undecided → High
tags: added: feature-request installation
Changed in easybreezy:
assignee: nobody → HBCoders (hbcoders)

[Notes re: installer]
We have some choices here: the actions requiring the presence of the bzrdefaults file could be disabled if it does not exist (simplest) or the chooser / setup could be run if the file does not exist (and the options always be available).
Alternatively, there could be a setup option (where bzrdefaults does not exist) and then a chooser option once it does exist ('add a repository' or somesuch).

Actually, only checkout and new project have a problem. Add and Commit uses the existing .bzr settings.

Rory Ladyman (rwbl) on 2019-06-17
description: updated

Added (in repochoice series):

sshpass;~/.local/share/nemo/actions/bzrdefaults; to Dependencies section in bzrcheckout.nemo_action and bzrnewproject.nemo_action, so that they do not show as options if the bzrdefaults file does not exist or sshpass has not been installed. (This is for Nemo).

Unfortunately, the Dependencies section won't allow relative paths, so ~ cannot be use (/home/username is needed instead). Also, we'd have to modify both the Nemo and Thunar settings: it will be better, I think, to modify the shell scripts to check for a missing bzrdefaults instead.

Added checks to runnewproject.sh and runcheckout.sh - this means that the fix now works for Thunar as well.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints