base_sale_multichannel: Fault select

[Daniel Stenlöv]

            cr.execute("select * from ir_module_module where name=%s and state=%s" %
                                                            ('product_m2mcategories', 'installed'))

The statement above will produces the wrong SQL-statement and will break connection between openerp 6.1 <-> magento if product_m2mcategories is installed.

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Could you provide in your description:
A) The expected output (SQL statement)
B) The actual output (SQL statement)

I cannot review your MP since it seems, at a glance, to provide the same statement.

[Daniel Stenlöv (daniel-stenlov-xclude)]

Original:
cr.execute('select * from ir_module_module where name=%s and state=%s', ('product_m2mcategories','installed'))

Will produce SQL statement:
select * from ir_module_module where name=product_m2mcategories and state=installed

Changed:
cr.execute("select * from ir_module_module where name='product_m2mcategories' and state='installed'")

Will produce SQL statement:
select * from ir_module_module where name='product_m2mcategories' and state='installed'

Comment:
The difference is that name='...' is a string in column name and name=product_m2mcategories is a column called product_m2mcategories compared to column name...

[Daniel Stenlöv (daniel-stenlov-xclude)]

Just a small note:

cr.execute("select * from ir_module_module where name='%s' and state='%s'", ('product_m2mcategories','installed'))

Will also produce the correct SQL statement. However since the other way was used mostly in the code I changed it to that.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Daniel,

In your original bug report, the query was:

            cr.execute("select * from ir_module_module where name=%s and state=%s" %
                                                            ('product_m2mcategories', 'installed'))

Indeed, this code is wrong and would produce

select * from ir_module_module where name=product_m2mcategories and state=installed

However, the current code is

cr.execute('select * from ir_module_module where name=%s and state=%s', ('product_m2mcategories','installed'))

Which is correct. Using params is useless as the values are static, but the query is still valid. See http://initd.org/psycopg/docs/usage.html

Thanks