Activity log for bug #1624725

Date Who What changed Old value New value Message
2016-09-17 20:27:06 Aaron Whitehouse bug added bug
2016-09-17 20:27:18 Aaron Whitehouse description Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Clause in Bug #1479545: "I had a command line similar to --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup!" This bug was introduced at rev 1112 of the 0.7-series. Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Claus in Bug #1479545: "I had a command line similar to   --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup!" This bug was introduced at rev 1112 of the 0.7-series.
2016-09-17 20:27:59 Aaron Whitehouse description Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Claus in Bug #1479545: "I had a command line similar to   --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup!" This bug was introduced at rev 1112 of the 0.7-series. Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Claus in Bug #1479545: "I had a command line similar to   --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup! By changing behavior back and forth you probably messed up a lot of backups everywhere and many users are probably not aware that their files are currently not in the backup! My suggestion on how to cleanup this mess: a) Change back once again (It is better there are to many files in backup than to little). b) Introduce an explicit switch e.g. "--include-dirs-only <your-dir>" for the old behavior At least point out this old/new very unintuitive behavior in the man page please. Sorry if this sounds a little harsh, I am not writing this to yell at people who are only trying to help others. But I am very concerned about users/admins having a data loss and then noticing their backups are useless." This bug was introduced at rev 1112 of the 0.7-series.
2016-09-17 20:41:38 Aaron Whitehouse duplicity: assignee Aaron Whitehouse (aaron-whitehouse)
2016-09-17 20:41:43 Aaron Whitehouse duplicity: importance Undecided High
2016-09-17 20:41:49 Aaron Whitehouse duplicity: status New Confirmed
2016-09-17 20:52:33 Aaron Whitehouse bug added subscriber claus
2016-09-17 22:05:47 Aaron Whitehouse description Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Claus in Bug #1479545: "I had a command line similar to   --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup! By changing behavior back and forth you probably messed up a lot of backups everywhere and many users are probably not aware that their files are currently not in the backup! My suggestion on how to cleanup this mess: a) Change back once again (It is better there are to many files in backup than to little). b) Introduce an explicit switch e.g. "--include-dirs-only <your-dir>" for the old behavior At least point out this old/new very unintuitive behavior in the man page please. Sorry if this sounds a little harsh, I am not writing this to yell at people who are only trying to help others. But I am very concerned about users/admins having a data loss and then noticing their backups are useless." This bug was introduced at rev 1112 of the 0.7-series. Including a folder with an --include ending in "/" does not include folder contents. Including the folder with the same --include without the "/" does include contents. As reported by Claus in Bug #1479545: "I had a command line similar to   --include ~/very/important/stuff/here/needs/backup/ --exclude '**' Now of course I checked the backups when I set this up and everything was fine. Recently I noticed that backups are very fast (too fast for the amount of data) and found that all files are missing in the backup! By changing behavior back and forth you probably messed up a lot of backups everywhere and many users are probably not aware that their files are currently not in the backup! My suggestion on how to cleanup this mess: a) Change back once again (It is better there are to many files in backup than to little). b) Introduce an explicit switch e.g. "--include-dirs-only <your-dir>" for the old behavior At least point out this old/new very unintuitive behavior in the man page please. Sorry if this sounds a little harsh, I am not writing this to yell at people who are only trying to help others. But I am very concerned about users/admins having a data loss and then noticing their backups are useless." This bug was introduced at rev 1112 of the 0.7-series, though note that include and exclude lines including any globbing patterns (including *) were pretty fundamentally broken prior to rev 1110 (Bug #932482) anyway, so the main people who will be seeing a regression will be those who do not use globs in the relevant directory include/exclude line.
2016-09-17 23:14:23 Aaron Whitehouse summary Including a folder ending in "/" does not include contents Including a folder ending in "/" does not include folder contents
2016-09-20 20:52:21 Aaron Whitehouse duplicity: status Confirmed In Progress
2016-09-29 21:48:13 Aaron Whitehouse branch linked lp:~aaron-whitehouse/duplicity/Bug_1624725_files_within_folder_slash
2016-12-11 16:46:04 Kenneth Loafman duplicity: status In Progress Fix Committed
2016-12-11 16:46:04 Kenneth Loafman duplicity: milestone 0.7.11
2016-12-11 16:46:04 Kenneth Loafman duplicity: assignee Aaron Whitehouse (aaron-whitehouse)
2016-12-31 16:43:13 Kenneth Loafman duplicity: status Fix Committed Fix Released