--include-globbing-filelist and --exclude-globbing-filelist should be removed (all filelists should be globbing)
Bug #1423366 reported by
Aaron Whitehouse
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Duplicity |
Fix Released
|
Medium
|
Aaron Whitehouse |
Bug Description
As per:
http://
and:
http://
There is no reason to have both globbing and non-globbing filelist options. Globbing should be permitted in all cases. The --include-
Related branches
lp:~aaron-whitehouse/duplicity/filelist_combine
- duplicity-team: Pending requested
-
Diff: 2740 lines (+683/-919)7 files modifiedbin/duplicity.1 (+20/-82)
duplicity/commandline.py (+27/-4)
duplicity/selection.py (+27/-128)
po/duplicity.pot (+99/-106)
testing/functional/test_selection.py (+203/-193)
testing/stdin_test.sh (+203/-0)
testing/unit/test_selection.py (+104/-406)
Changed in duplicity: | |
assignee: | nobody → Aaron Whitehouse (aaron-whitehouse) |
Changed in duplicity: | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
To post a comment you must log in.
"New in v0.7.03 (2015/05/11) ------- ------- ------ globbing- filelist and include- globbing- filelist options in globbing- filelist was used. Additional lines will therefore
-------
* Merged in lp:~aaron-whitehouse/duplicity/filelist_combine
- Merged globbing and non-globbing filelists to use the same code path
and all accept globbing characters. Added deprecation warning to the
--exclude-
commandline.py and hid them from help output. Updated the manual
(and unit tests) accordingly.
- Note that this does trigger a change in behaviour for duplicity.
Previously, include patterns in include-filelist did not match files
in a directory that was included, so /usr/local in an include file
would not have matched /usr/local/doc. Now, this folder would be
included, as would occur if --include or the old
--include-
need to be added to filelists to unambiguously exclude unwanted
subfolders, if this is intended."