--include-globbing-filelist and --exclude-globbing-filelist should be removed (all filelists should be globbing)

Bug #1423366 reported by Aaron Whitehouse
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Duplicity
Fix Released
Medium
Aaron Whitehouse

Bug Description

As per:
http://lists.nongnu.org/archive/html/duplicity-talk/2015-01/msg00011.html
and:
http://lists.nongnu.org/archive/html/duplicity-talk/2015-01/msg00014.html

There is no reason to have both globbing and non-globbing filelist options. Globbing should be permitted in all cases. The --include-globbing-filelist and --exclude-globbing-filelist options should be deprecated (and removed in a later version). --include-filelist and --exclude-filelist should accept globbing characters.

Related branches

Changed in duplicity:
assignee: nobody → Aaron Whitehouse (aaron-whitehouse)
Changed in duplicity:
status: New → Fix Committed
importance: Undecided → Medium
Revision history for this message
Aaron Whitehouse (aaron-whitehouse) wrote :

"New in v0.7.03 (2015/05/11)
---------------------------
* Merged in lp:~aaron-whitehouse/duplicity/filelist_combine
  - Merged globbing and non-globbing filelists to use the same code path
    and all accept globbing characters. Added deprecation warning to the
    --exclude-globbing-filelist and include-globbing-filelist options in
    commandline.py and hid them from help output. Updated the manual
    (and unit tests) accordingly.
  - Note that this does trigger a change in behaviour for duplicity.
    Previously, include patterns in include-filelist did not match files
    in a directory that was included, so /usr/local in an include file
    would not have matched /usr/local/doc. Now, this folder would be
    included, as would occur if --include or the old
    --include-globbing-filelist was used. Additional lines will therefore
    need to be added to filelists to unambiguously exclude unwanted
    subfolders, if this is intended."

Changed in duplicity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.