Duplicity does not exit after an OSError

Bug #1395341 reported by Claudio Gil on 2014-11-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Duplicity
Medium
Unassigned
0.6-series
Medium
Unassigned

Bug Description

When backing up a locally mounted cifs share with encryption and an OSError occurs duplicity process does not exit. It does the final actions of removing the unlock file and printing the error but never stops and has a child gpg process hanging.

duplicity: 0.6.24
python: 2.7.3
os: debian wheezy
source fs: locally mounted cifs
target fs: S3

The last two lines of the log are after a "kill -9" to child gpg process. Between those lines and the OSError immediately before several minutes have passed.

Related branches

Claudio Gil (m4ktub) wrote :
description: updated
Claudio Gil (m4ktub) wrote :

The attached patch changes GPGWriteFile, in duplicity/gpg.py, to wrap the iteration in a try-exception. This way, in case of error the GPGFile is still closed and the sub process terminates.

Changed in duplicity:
milestone: none → 0.7.01
Changed in duplicity:
importance: Undecided → Medium
status: New → Fix Committed
Changed in duplicity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments