exclude-globbing-filelist does not backup correct files with --progress option
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Duplicity |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Hi, tnx for duplicity.
I'm trying to use duplicity with duply, and I want to use the exclude-
For testing purpose I created a bk dir, this is the structure
/home/jorman/
|-- file1
|-- file2
|-- file3
|-- subfolder1
| `-- file4
| `-- file5
| `-- file6
|-- subfolder2
| `-- file7
| `-- file8
| `-- file9
Each folder contains 3 files, so 9 in total
My exclusion list is that
- /home/jorman/
The command line is
export PASSPHRASE=XXX
duplicity --encrypt-key "YYY" --dry-run --verbosity 9 --full-
Now, the result log report that
--------------[ Statistiche del backup ]--------------
StartTime 1388264800.61 (Sat Dec 28 22:06:40 2013)
EndTime 1388264800.62 (Sat Dec 28 22:06:40 2013)
ElapsedTime 0.01 (0.01 seconds)
SourceFiles 21
SourceFileSize 12288 (12.0 KB)
NewFiles 12
NewFileSize 12288 (12.0 KB)
DeletedFiles 0
ChangedFiles 0
ChangedFileSize 0 (0 bytes)
ChangedDeltaSize 0 (0 bytes)
DeltaEntries 12
RawDeltaSize 0 (0 bytes)
TotalDestinatio
Errors 0
-------
As you can see Duplicity try to add 12 files, but if I exclude the dir 1 the files must be only 8
Now I read the duplicity file selection, and if I decided to expand the argument so the command line is that
duplicity --encrypt-key "YYY" --dry-run --verbosity 9 --full-
And the result log is
--------------[ Statistiche del backup ]--------------
StartTime 1388265307.57 (Sat Dec 28 22:15:07 2013)
EndTime 1388265307.57 (Sat Dec 28 22:15:07 2013)
ElapsedTime 0.00 (0.00 seconds)
SourceFiles 14
SourceFileSize 8192 (8.00 KB)
NewFiles 8
NewFileSize 8192 (8.00 KB)
DeletedFiles 0
ChangedFiles 0
ChangedFileSize 0 (0 bytes)
ChangedDeltaSize 0 (0 bytes)
DeltaEntries 8
RawDeltaSize 0 (0 bytes)
TotalDestinatio
Errors 0
-------
That is exact
What I wrong?
J
Related branches
- duplicity-team: Pending requested
-
Diff: 45 lines (+35/-0)1 file modifiedtesting/functional/test_selection.py (+35/-0)
- Aaron Whitehouse: Approve
-
Diff: 11 lines (+1/-0)1 file modifiedduplicity/selection.py (+1/-0)
Changed in duplicity: | |
importance: | Undecided → Medium |
milestone: | none → 0.7.04 |
status: | New → Fix Committed |
Changed in duplicity: | |
status: | Fix Committed → Fix Released |
Hi,
I think this problem is result from reading twice filelist file.
For example:
~/tmp/test-> tree -a in
in
├── .config
│ └── test1-in-config.txt
├── test2.txt
└── test3.txt
~/tmp/test-> cat filelist.txt tmp/test/ in/.config
- /home/k/
duplicity -vi --progress --no-encryption --exclude- globbing- filelist filelist.txt /home/k/ tmp/test/ in/ file:// /home/k/ tmp/test/ out/ .cache/ duplicity/ b5e2f4b829db693 41672537d1ced33 77 41672537d1ced33 77
Using archive dir: /home/k/
Using backup name: b5e2f4b829db693
[....]
Reading globbing filelist filelist.txt
[******** First reading file list]
Main action: inc ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= === globbing- filelist filelist.txt /home/k/ tmp/test/ in/ file:// /home/k/ tmp/test/ out/ ======= ======= ======= ======= ======= ======= ======= ======= ======= ======= === iljo9e- tempdir
=======
duplicity 0.6.23 (January 24, 2014)
Args: /usr/bin/duplicity -vi --progress --no-encryption --exclude-
Linux kntbk 3.13-1-686-pae #1 SMP Debian 3.13.5-1 (2014-03-04) i686
/usr/bin/python 2.7.6 (default, Feb 26 2014, 06:42:04)
[GCC 4.8.2]
=======
Using temporary directory /tmp/duplicity-
Temp has 47721136128 available, backup will use approx 34078720.
Local and Remote metadata are synchronized, no sync needed.
Last full backup date: none
No signatures found, switching to full backup.
A .
A test2.txt
A test3.txt
[******** In this point file list is correct, below - second reading filelist ]
Reading globbing filelist filelist.txt .cache/ duplicity/ b5e2f4b829db693 41672537d1ced33 77/duplicity- HXwYmn- tempdir .cache/ duplicity/ b5e2f4b829db693 41672537d1ced33 77/duplicity- wbRfbF- tempdir test1-in- config. txt
Using temporary directory /home/k/
Using temporary directory /home/k/
AsyncScheduler: instantiating at concurrency 0
A .
A .config
A .config/
A test2.txt
A test3.txt
[******** in this point exclude list is empty]
[...]
IMHO - file with exclude list is simple not reopened.
Similar problem: tmp/test/ in/ file:// /home/k/ tmp/test/ out/
duplicity --progress --no-encryption --exclude-filelist filelist.txt /home/k/
Reading filelist filelist.txt duplicity" , line 1495, in <module> tempdir( main) duplicity" , line 1489, in with_tempdir duplicity" , line 1338, in main backup( action) duplicity" , line 1471, in do_backup _backup( sig_chain) duplicity" , line 623, in incremental_backup .set_selection( ) python2. 7/dist- packages/ duplicity/ commandline. py", line 891, in set_selection ParseArgs( select_ opts, select_files) python2. 7/dist- packages/ duplicity/ selection. py", line 235, in ParseArgs filelists_ index], 0, arg)) python2. 7/dist- packages/ duplicity/ selection. py", line 313, in filelist_get_sf filelist_ read(filelist_ fp, inc_default, filelist_name) python2. 7/dist- packages/ duplicity/ selection. py", l...
Sorting filelist filelist.txt
Local and Remote metadata are synchronized, no sync needed.
Last full backup date: Thu Mar 13 18:26:27 2014
Reading filelist filelist.txt
Traceback (most recent call last):
File "/usr/bin/
with_
File "/usr/bin/
fn()
File "/usr/bin/
do_
File "/usr/bin/
incremental
File "/usr/bin/
commandline
File "/usr/lib/
sel.
File "/usr/lib/
filelists[
File "/usr/lib/
self.
File "/usr/lib/