Fix parameter order for Tree.add

Bug #663550 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Dulwich
Fix Released
Low
Jelmer Vernooij

Bug Description

  affects dulwich
  status triaged
  importance low

On Tue, 2010-10-19 at 10:07 -0700, David Borowitz wrote:
> On Sat, Oct 16, 2010 at 14:59, Jelmer Vernooij <email address hidden>
> wrote:
> On Fri, 2010-10-08 at 12:51 -0700, David Borowitz wrote:
> > Another place with a completely different order:
> Tree.add(mode, name,
> > sha). I don't suppose that's one we can safely change, is
> it?
>
> I guess we could check the types of mode and name and reverse
> them (and
> print a DeprecationWarning) if they're wrong.
>
> It's not entirely nice but I think the cleanest way of fixing
> it.
>
>
> Yeah. I don't have a sense of whether this is a thing other Python
> projects do...
>
>
> I'm happy to make this change but it's not on my critical path at the
> moment.

Related branches

Jelmer Vernooij (jelmer)
Changed in dulwich:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in dulwich:
status: In Progress → Fix Committed
milestone: none → 0.7.1
Jelmer Vernooij (jelmer)
Changed in dulwich:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.