A Lightweight SQL Database for Cloud Infrastructure and Web Applications

Module pointer not removed from registry when plugin load fails

Reported by Andrew Hutchings on 2010-08-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Medium
Andrew Hutchings
7.0
Medium
Andrew Hutchings
Dexter
Medium
Andrew Hutchings

Bug Description

When a module fails to initialize in plugin_finalize it is cleaned up but the module's pointer is still stored in registry so during shutdown the loader tries to remove the module again causing a segfault.

I have reproduced this by making InnoDB plugin fail to start.

To fix this the following code in plugin_finalize also needs to remove the module from the registry:

      if (plugin_initialize(registry, module))
        delete_module(module);

Changed in drizzle:
importance: Undecided → Medium
Lee Bieber (kalebral) on 2010-08-12
Changed in drizzle:
assignee: nobody → Andrew Hutchings (thelinuxjedi)
status: New → Confirmed
Changed in drizzle:
status: Confirmed → In Progress
Andrew Hutchings (linuxjedi) wrote :

Awaiting Patrick to migrate some mtr2 features so we can build a test case for my fix

Changed in drizzle:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers