getlogin() needs changing
Bug #743902 reported by
Andrew Hutchings
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Drizzle |
Fix Released
|
High
|
Andrew Hutchings | ||
| 7.0 |
Won't Fix
|
High
|
SatoshiNakamoto | ||
| 7.1 |
Fix Released
|
High
|
Andrew Hutchings | ||
Bug Description
In the drizzle clients we use getlogin(). We need to:
1. change this to getpwuid(geteuid()) for various reasons (getlogin() doesn't work in several cases, causes a valgrind leak, etc...)
2. add it to console plugin
Related branches
lp:~linuxjedi/drizzle/trunk-bug-743902
- Drizzle Merge Team: Pending requested
-
Diff: 95 lines (+2/-15)4 files modifieddrizzled/plugin/client.h (+0/-5)
plugin/schema_dictionary/tests/r/data_dictionary.result (+1/-5)
plugin/session_dictionary/sessions.cc (+0/-4)
tests/valgrind.supp (+1/-1)
lp:~linuxjedi/drizzle/elliott-bug-743902
- Stewart Smith (community): Approve
-
Diff: 199 lines (+83/-7)6 files modifiedclient/drizzle.cc (+5/-2)
client/drizzledump.cc (+5/-2)
client/drizzleimport.cc (+5/-2)
client/include.am (+1/-0)
client/user_detect.h (+62/-0)
plugin/console/console.cc (+5/-1)
| Changed in drizzle: | |
| importance: | Undecided → High |
Revision history for this message
| Andrew Hutchings (linuxjedi) wrote | #1 |
To post a comment you must log in.
Lee: this has minor security implications in our GA so probably will need backporting to Elliott too