build-failure on FreeBSD

[coldtobi]

On the Debian build farm the package fails to build on kfreebsd:
It seems that O_CLOEXCEC is not supported by glibc-bsd. (See also [1])

drizzled/drizzled.cc:399:77: error: 'O_CLOEXEC' was not declared in this scope.

You can find the complete logs at:
https://buildd.debian.org/status/fetch.php?pkg=drizzle&arch=kfreebsd-i386&ver=1%3A7.1.32-rc-1&stamp=1334052115
and
https://buildd.debian.org/status/fetch.php?pkg=drizzle&arch=kfreebsd-amd64&ver=1%3A7.1.32-rc-1&stamp=1334051953

Tobias

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635192):

[coldtobi (tobi-coldtobi)]

I took a look at the code:
(http://bazaar.launchpad.net/~drizzle-trunk/drizzle/greenlake/view/head:/drizzled/drizzled.cc#L395)
The open in question is in the function to open the pid file. The commit text to the changes reads
"We now create pid before we startup plugins, therefor allowing us to bail sooner in the process."

So - without knowing the internals -- I assume that at that point of time drizzle forked already, but no other process / thread has been spawned.
In this case, it the O_CLOEXEC won't be needed and the patch trivial..

Can you confirm?

(NB: This bug is release crticial for Debian, that is without a fix for it, it won't make it to the next stable release. However, I can add a Debian specific patch, so you do not need to make an extra release for that... I just want to make sure that this patch won't break other things)

Tobias

[Henrik Ingo (hingo)]

Without looking at the code: The fix you cite was about opening pid file as root, before dropping privileges. I assume this means it is done before the fork?