regex_policy should use apache like ALLOW/DENY
Bug #931917 reported by
Henrik Ingo
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Committed
|
Low
|
Unassigned |
Bug Description
In auth_regex the pair of commands ACCEPT/DENY is confusing. It should have been either ACCEPT/REJECT (see iptables) or ALLOW/DENY (see apache httpd). My proposal is to make it ALLOW/DENY.
The fix should of course be backward compatible and still also support ACCEPT/DENY, but documentation should mark this usage as deprecated.
Related branches
lp:~ansharyan015/drizzle/trunk-bug-931917
- Henrik Ingo: Approve
-
Diff: 385 lines (+250/-36)8 files modifiedplugin/regex_policy/docs/index.rst (+14/-18)
plugin/regex_policy/module.cc (+1/-1)
plugin/regex_policy/policy.h (+6/-6)
plugin/regex_policy/tests/r/basic_deprecated.result (+72/-0)
plugin/regex_policy/tests/t/basic.policy (+11/-11)
plugin/regex_policy/tests/t/basic_deprecated-master.opt (+1/-0)
plugin/regex_policy/tests/t/basic_deprecated.policy (+15/-0)
plugin/regex_policy/tests/t/basic_deprecated.test (+130/-0)
tags: | added: regex-policy-plugin |
To post a comment you must log in.
On Tue, 14 Feb 2012 08:20:51 -0000, Henrik Ingo <email address hidden> wrote:
> In auth_regex the pair of commands ACCEPT/DENY is confusing. It should
> have been either ACCEPT/REJECT (see iptables) or ALLOW/DENY (see apache
> httpd). My proposal is to make it ALLOW/DENY.
Maybe allow all 4, with ACCEPT/REJECT being synonyms for ALLOW/DENY and
then it should all "just work"? :)
--
Stewart Smith