listen_tcp: bind() errors produce a confusing error message

Bug #720976 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Low
Unassigned
7.0
Fix Released
Low
Unassigned

Bug Description

The message that is printed when drizzle fails to bind to a port is confusing because it does not tell you which port it failed to bind on, and it this may be following successful binds to other ports, implying that it failed to bind to those.

This patch makes it much clearer:

=== modified file 'drizzled/plugin/listen_tcp.cc'
--- drizzled/plugin/listen_tcp.cc 2011-02-05 20:07:57 +0000
+++ drizzled/plugin/listen_tcp.cc 2011-02-17 21:27:31 +0000
@@ -186,7 +186,7 @@

     if (ret < 0)
     {
- sql_perror(_("bind() Do you already have another drizzled running?"));
+ errmsg_printf(error::INFO, _("bind() to %s:%s failed"), host_buf, port_buf);
       return true;
     }

Tags: patch

Related branches

Changed in drizzle:
status: New → Confirmed
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.