get rid of exported global variables

Bug #707323 reported by Monty Taylor on 2011-01-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Low
Unassigned

Bug Description

The following list is not honestly very terrible - but most likely all of these should be abstracted behind an accessor or something. These are all of the global variables that plugins are accessing directly - which means we have to expose them in the linker.

drizzled/internal/my_static.cc:42:DRIZZLED_API int my_umask=0664;
drizzled/plugin/storage_engine.h:128:extern DRIZZLED_API const std::string DEFAULT_DEFINITION_FILE_EXT;
drizzled/charset.cc:134:DRIZZLED_API CHARSET_INFO *all_charsets[256];
drizzled/charset.cc:135:const DRIZZLED_API CHARSET_INFO *default_charset_info = &my_charset_utf8_general_ci;
drizzled/drizzled.cc:236:DRIZZLED_API bool volatile shutdown_in_progress;
drizzled/drizzled.cc:240:DRIZZLED_API size_t my_thread_stack_size= 0;
drizzled/drizzled.cc:256:DRIZZLED_API uint32_t server_id;
drizzled/drizzled.cc:310:DRIZZLED_API char glob_hostname[FN_REFLEN];
drizzled/drizzled.cc:330:DRIZZLED_API drizzle_system_variables global_system_variables;
drizzled/drizzled.cc:334:DRIZZLED_API const CHARSET_INFO *system_charset_info;
drizzled/drizzled.cc:347:DRIZZLED_API boost::condition_variable COND_thread_count;
drizzled/ctype-bin.cc:524:DRIZZLED_API CHARSET_INFO my_charset_bin =
drizzled/ctype-utf8.cc:2720:DRIZZLED_API CHARSET_INFO my_charset_utf8mb4_general_ci=
drizzled/ctype-utf8.cc:2755:DRIZZLED_API CHARSET_INFO my_charset_utf8mb4_bin=
drizzled/sql_list.cc:26:DRIZZLED_API list_node end_of_list;

Related branches

Lee Bieber (kalebral) on 2011-01-25
Changed in drizzle:
importance: Undecided → Low
status: New → Confirmed
milestone: none → future
Stewart Smith (stewart) wrote :

I've fixed these two:

drizzled/internal/my_static.cc:42:DRIZZLED_API int my_umask=0664;
drizzled/plugin/storage_engine.h:128:extern DRIZZLED_API const std::string DEFAULT_DEFINITION_FILE_EXT;

Changed in drizzle:
status: Confirmed → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers