Drizzle

show create table and friends are using backticks

Bug #702556 reported by Brian Aker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Confirmed
Medium
Unassigned
Drizzle future
7.0
Won't Fix
Medium
Unassigned
Drizzle future

Bug Description

Show create table is spitting out backticks, it should be quotes.

Revision history for this message
David Shrewsbury (dshrews) wrote :

I think this is using statement_transform.cc calls. Will investigate.

Changed in drizzle:
assignee: nobody → David Shrewsbury (dshrews)
Revision history for this message
David Shrewsbury (dshrews) wrote :

Yep. transformTableDefinitionToSql() called from plugin/show_dictionary/show_create_table.cc.

Do we want the option of using backticks, or just always use double quotes around identifiers?

Revision history for this message
David Shrewsbury (dshrews) wrote :

From IRC conversation:

Shrews: krow: so do we want to support backticks at all? or just always use double quotes?
krow: Shrews: We should always parse them, but we should output SQL quotes.

Revision history for this message
David Shrewsbury (dshrews) wrote :

Back to IN PROGRESS. Have to re-record Haildb tests.

Revision history for this message
David Shrewsbury (dshrews) wrote :

Waiting for some other changes to hit trunk before merging. This changes A LOT of recorded test results.

Revision history for this message
Stewart Smith (stewart) wrote :

The reason the backticks are in statement_transform is that this is what the original SHOW CREATE TABLE code did, and changing the output and the implementation in one go would have been dumb-ass :)

Revision history for this message
David Shrewsbury (dshrews) wrote :

Stuck. Dependent on https://bugs.launchpad.net/drizzle/+bug/708272.

David Shrewsbury (dshrews)
Changed in drizzle:
assignee: David Shrewsbury (dshrews) → nobody
nflfdglkfm b (lvmfldbmflmb)
summary: - show create table and friends are using backticks
+ You can Buy Cheap Ambien online as per your doctor’s recommendations.
description: updated
Colin Watson (cjwatson)
summary: - You can Buy Cheap Ambien online as per your doctor’s recommendations.
+ show create table and friends are using backticks
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.