filesystem_engine.multiple_update test failure on OSX

[Lee Bieber]

On my Mac I get this test failure with filesystem_engine multiple_update, but even more disturbing is that the test data is getting updated after I run the test. See below:

$ ./dtr --suite=filesystem_engine multiple_update
Logging: ./dtr --suite=filesystem_engine multiple_update
Drizzle Version 2010.08.1718
Using MTR_BUILD_THREAD = -69.4
Using MASTER_MYPORT = 9306
Using MASTER_MYPORT1 = 9307
Using SLAVE_MYPORT = 9308
Using SLAVE_MYPORT1 = 9309
Using SLAVE_MYPORT2 = 9310
Using MC_PORT = 9316
Killing Possible Leftover Processes
Removing Stale Files
Creating Directories
================================================================================
DEFAULT STORAGE ENGINE: innodb
TEST RESULT TIME (ms)
--------------------------------------------------------------------------------

filesystem_engine.multiple_update [ fail ]
drizzletest: At line 248: query 'UPDATE t1 SET a=555 WHERE a=666' failed: 1030: Got error 24 from storage engine

The result from queries just before the failure was:
< snip >
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;
UPDATE t1 SET a=666 WHERE a=555;
UPDATE t1 SET a=555 WHERE a=666;

More results from queries before failure can be found in /Users/lbieber/repos/trunk/tests/var/log/multiple_update.log

% bzr status
modified:
  plugin/filesystem_engine/tests/t/multiple_update.data

[David Shrewsbury (dshrews)]

CURRENT_TEST: filesystem_engine.multiple_update
drizzletest: At line 248: query 'UPDATE t1 SET a=555 WHERE a=666' failed: 1030: Got error 24 from storage engine

Davids-iMac:~ david$ perror 24
OS error code 24: Too many open files

Default Mac OS X limit of open files = 256
Default Linux limit of open files = 1024

It seems, from a quick inspection of the test, that for each UPDATE, a new file handle is acquired and never closed. Bug in the engine?

[Lee Bieber (kalebral-deactivatedaccount)]

I just confirmed this by changing the open files limit to 1024 on my Mac and the test now passes

[Monty Taylor (mordred)]

On 09/16/2010 11:51 AM, Lee Bieber wrote:
> I just confirmed this by changing the open files limit to 1024 on my Mac
> and the test now passes
>

Can we perhaps just have test-run.pl set open files limit if it's on a mac?

[David Shrewsbury (dshrews)]

Nope. That just hides the bug, which needs fixed.