table proto having default_null set to false falsely has default value (that isn't null)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Released
|
Low
|
Stewart Smith | ||
Dexter |
Fix Released
|
Low
|
Stewart Smith |
Bug Description
turns out the table_function code was the only thing hitting it.
having default_null set to false (instead of defaulting to not having it) causes this condition to be hit when parsing it:
if (pfield.
{
default_
}
when it really shouldn't be.
this gives something like this in SHOW CREATE TABLE:
`CHARACTER_
instead of
`CHARACTER_
Related branches
- Brian Aker: Approve
-
Diff: 1279 lines (+443/-443)22 files modifieddrizzled/table_share.cc (+1/-1)
plugin/collation_dictionary/tests/r/data_dictionary.result (+11/-11)
plugin/information_schema_dictionary/tests/r/show_create_table.result (+233/-233)
plugin/innobase/tests/r/innodb_cmp.result (+6/-6)
plugin/innobase/tests/r/innodb_cmp_reset.result (+6/-6)
plugin/innobase/tests/r/innodb_cmpmem.result (+5/-5)
plugin/innobase/tests/r/innodb_cmpmem_reset.result (+5/-5)
plugin/innobase/tests/r/innodb_lock_waits.result (+4/-4)
plugin/innobase/tests/r/innodb_locks.result (+10/-10)
plugin/innobase/tests/r/innodb_status.result (+2/-2)
plugin/innobase/tests/r/innodb_trx.result (+8/-8)
plugin/logging_stats/tests/r/command.result (+2/-2)
plugin/logging_stats/tests/r/max_user.result (+2/-2)
plugin/registry_dictionary/tests/r/data_dictionary.result (+11/-11)
plugin/replication_dictionary/tests/r/data_dictionary.result (+2/-2)
plugin/schema_dictionary/tests/r/data_dictionary.result (+61/-61)
plugin/session_dictionary/tests/r/data_dictionary.result (+8/-8)
plugin/status_dictionary/tests/r/data_dictionary.result (+8/-8)
plugin/table_cache_dictionary/tests/r/table_cache.result (+9/-9)
plugin/table_cache_dictionary/tests/r/table_definition_cache.result (+5/-5)
tests/r/create.result (+16/-16)
tests/r/show_check.result (+28/-28)
Changed in drizzle: | |
status: | Confirmed → Fix Committed |
Changed in drizzle: | |
milestone: | 2010-07-05 → 2010-07-19 |
Changed in drizzle: | |
milestone: | 2010-07-19 → 2010-08-02 |
Changed in drizzle: | |
milestone: | 2010-08-02 → 2010-08-14 |