valgrind error in filesort

[Monty Taylor]

==9651== Syscall param write(buf) points to uninitialised byte(s)
==9651== at 0x65AD04B: ??? (in /lib/libpthread-2.10.1.so)
==9651== by 0x674F2D: drizzled::internal::my_write(int, unsigned char const*, unsigned long, int) (my_write.cc:41)
==9651== by 0x670C1E: drizzled::internal::my_b_flush_io_cache(drizzled::internal::st_io_cache*, int) (mf_iocache.cc:1578)
==9651== by 0x67128B: drizzled::internal::_my_b_write(drizzled::internal::st_io_cache*, unsigned char const*, unsigned long) (mf_iocache.cc:1424)
==9651== by 0x515E16: drizzled::write_keys(drizzled::st_sort_param*, unsigned char**, unsigned int, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:681)
==9651== by 0x51871D: drizzled::filesort(drizzled::Session*, drizzled::Table*, drizzled::st_sort_field*, unsigned int, drizzled::optimizer::SqlSelect*, unsigned long, bool, unsigned long*) (filesort.cc:588)
==9651== by 0x612E76: drizzled::create_sort_index(drizzled::Session*, drizzled::JOIN*, drizzled::order_st*, unsigned long, unsigned long, bool) (sql_select.cc:5296)
==9651== by 0x58B2C7: drizzled::JOIN::exec() (join.cc:1645)
==9651== by 0x6099E1: drizzled::mysql_select(drizzled::Session*, drizzled::Item***, drizzled::TableList*, unsigned int, drizzled::List<drizzled::Item>&, drizzled::Item*, unsigned int, drizzled::order_st*, drizzled::order_st*, drizzled::Item*, unsigned long, drizzled::select_result*, drizzled::Select_Lex_Unit*, drizzled::Select_Lex*) (sql_select.cc:427)
==9651== by 0x60A2AF: drizzled::handle_select(drizzled::Session*, drizzled::LEX*, drizzled::select_result*, unsigned long) (sql_select.cc:146)
==9651== by 0x603A54: drizzled::execute_sqlcom_select(drizzled::Session*, drizzled::TableList*) (sql_parse.cc:543)
==9651== by 0x6037D2: drizzled::mysql_execute_command(drizzled::Session*) (sql_parse.cc:478)
==9651== by 0x605024: drizzled::mysql_parse(drizzled::Session*, char const*, unsigned int) (sql_parse.cc:733)
==9651== by 0x6054C4: drizzled::dispatch_command(drizzled::enum_server_command, drizzled::Session*, char*, unsigned int) (sql_parse.cc:223)
==9651== by 0x5D653E: drizzled::Session::executeStatement() (session.cc:685)
==9651== by 0x5D82F1: drizzled::Session::run() (session.cc:546)
==9651== Address 0x1b85906a is 10 bytes inside a block of size 65,536 alloc'd
==9651== at 0x4C25153: malloc (vg_replace_malloc.c:195)
==9651== by 0x670447: drizzled::internal::init_io_cache(drizzled::internal::st_io_cache*, int, unsigned long, drizzled::internal::cache_type, unsigned long, bool, int) (mf_iocache.cc:284)
==9651== by 0x66F35C: drizzled::internal::open_cached_file(drizzled::internal::st_io_cache*, char const*, char const*, unsigned long, int) (mf_cache.cc:49)
==9651== by 0x515EBE: drizzled::write_keys(drizzled::st_sort_param*, unsigned char**, unsigned int, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:669)
==9651== by 0x51871D: drizzled::filesort(drizzled::Session*, drizzled::Table*, drizzled::st_sort_field*, unsigned int, drizzled::optimizer::SqlSelect*, unsigned long, bool, unsigned long*) (filesort.cc:588)
==9651== by 0x612E76: drizzled::create_sort_index(drizzled::Session*, drizzled::JOIN*, drizzled::order_st*, unsigned long, unsigned long, bool) (sql_select.cc:5296)
==9651== by 0x58B2C7: drizzled::JOIN::exec() (join.cc:1645)
==9651== by 0x6099E1: drizzled::mysql_select(drizzled::Session*, drizzled::Item***, drizzled::TableList*, unsigned int, drizzled::List<drizzled::Item>&, drizzled::Item*, unsigned int, drizzled::order_st*, drizzled::order_st*, drizzled::Item*, unsigned long, drizzled::select_result*, drizzled::Select_Lex_Unit*, drizzled::Select_Lex*) (sql_select.cc:427)
==9651== by 0x60A2AF: drizzled::handle_select(drizzled::Session*, drizzled::LEX*, drizzled::select_result*, unsigned long) (sql_select.cc:146)
==9651== by 0x603A54: drizzled::execute_sqlcom_select(drizzled::Session*, drizzled::TableList*) (sql_parse.cc:543)
==9651== by 0x6037D2: drizzled::mysql_execute_command(drizzled::Session*) (sql_parse.cc:478)
==9651== by 0x605024: drizzled::mysql_parse(drizzled::Session*, char const*, unsigned int) (sql_parse.cc:733)
==9651== by 0x6054C4: drizzled::dispatch_command(drizzled::enum_server_command, drizzled::Session*, char*, unsigned int) (sql_parse.cc:223)
==9651== by 0x5D653E: drizzled::Session::executeStatement() (session.cc:685)
==9651== by 0x5D82F1: drizzled::Session::run() (session.cc:546)
==9651== by 0xA542071: session_thread (multi_thread.h:67)

[Monty Taylor (mordred)]

We have a suppression for this in the valgrind.supp file for now. Occasionally signature changes cause the suppression to stop suppressing.

[Lee Bieber (kalebral-deactivatedaccount)]

Current valgrind output from the main.sum_distinct test, will update valgrind.supp file

 Syscall param write(buf) points to uninitialised byte(s)
   at 0x77B7B2D: ??? (syscall-template.S:82)
   by 0x7274E1: drizzled::internal::my_write(int, unsigned char const*, unsigned long, int) (my_write.cc:42)
   by 0x722B0E: drizzled::internal::my_b_flush_io_cache(drizzled::internal::st_io_cache*, int) (mf_iocache.cc:881)
   by 0x722E0B: drizzled::internal::_my_b_write(drizzled::internal::st_io_cache*, unsigned char const*, unsigned long) (mf_iocache.cc:759)
   by 0x5A3D95: drizzled::SortParam::write_keys(unsigned char**, unsigned int, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:749)
   by 0x5A4EDA: drizzled::FileSort::find_all_keys(drizzled::SortParam*, drizzled::optimizer::SqlSelect*, unsigned char**, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:648)
   by 0x5A6A85: drizzled::FileSort::run(drizzled::Table*, drizzled::SortField*, unsigned int, drizzled::optimizer::SqlSelect*, unsigned long, bool, unsigned long&) (filesort.cc:339)
   by 0x6AF5C7: drizzled::create_sort_index(drizzled::Session*, drizzled::Join*, drizzled::Order*, unsigned long, unsigned long, bool) (sql_select.cc:5101)
   by 0x61F4DF: drizzled::Join::exec() (join.cc:1650)
   by 0x6A7341: drizzled::select_query(drizzled::Session*, drizzled::Item***, drizzled::TableList*, unsigned int, drizzled::List<drizzled::Item>&, drizzled::Item*, unsigned int, drizzled::Order*, drizzled::Order*, drizzled::Item*, unsigned long, drizzle
::select_result*, drizzled::Select_Lex_Unit*, drizzled::Select_Lex*) (sql_select.cc:432)
   by 0x6A7D7F: drizzled::handle_select(drizzled::Session*, drizzled::LEX*, drizzled::select_result*, unsigned long) (sql_select.cc:151)
   by 0x69F315: drizzled::execute_sqlcom_select(drizzled::Session*, drizzled::TableList*) (sql_parse.cc:545)
   by 0x6A172B: drizzled::parse(drizzled::Session*, char const*, unsigned int) (sql_parse.cc:480)
   by 0x6A22E9: drizzled::dispatch_command(drizzled::enum_server_command, drizzled::Session*, char*, unsigned int) (sql_parse.cc:228)
   by 0x679379: drizzled::Session::executeStatement() (session.cc:726)
   by 0x67DAFE: drizzled::Session::run() (session.cc:567)
 Address 0x18ab17ba is 10 bytes inside a block of size 65,536 alloc'd
   at 0x4C2815C: malloc (vg_replace_malloc.c:236)
   by 0x723487: drizzled::internal::st_io_cache::init_io_cache(int, unsigned long, drizzled::internal::cache_type, unsigned long, bool, int) (mf_iocache.cc:254)
   by 0x72220C: drizzled::internal::st_io_cache::open_cached_file(char const*, char const*, unsigned long, int) (iocache.cc:50)
   by 0x5A3DEE: drizzled::SortParam::write_keys(unsigned char**, unsigned int, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:730)
   by 0x5A4EDA: drizzled::FileSort::find_all_keys(drizzled::SortParam*, drizzled::optimizer::SqlSelect*, unsigned char**, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*, drizzled::internal::st_io_cache*) (filesort.cc:648)
   by 0x5A6A85: drizzled::FileSort::run(drizzled::Table*, drizzled::SortField*, ...