pbxt build errors [-Wsign-compare]

Bug #572633 reported by BJ Dierkes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
High
Paul McCullagh
Dexter
Fix Released
Undecided
Unassigned

Bug Description

Confirmed on RHEL 5, Fedora 12:

  CXXLD plugin/libmysql_protocol_plugin.la
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
cc1plus: warnings being treated as errors
plugin/pbxt/src/filesys_xt.cc: In function 'int xt_pwrite_file(XTOpenFile*, off_t, size_t, void*, XTIOStats*, XTThread*)':
plugin/pbxt/src/filesys_xt.cc:1506: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
plugin/pbxt/src/filesys_xt.cc:1530: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
plugin/pbxt/src/filesys_xt.cc: In function 'int xt_flush_file(XTOpenFile*, XTIOStats*, XTThread*)':
plugin/pbxt/src/filesys_xt.cc:1758: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
make[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/

Related branches

Changed in drizzle:
importance: Undecided → High
status: New → Confirmed
milestone: none → 2010-05-10
assignee: nobody → Monty Taylor (mordred)
Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi BJ,

I have made some changes that should fix the compile errors you reported above.

The changes are in: lp:~paul-mccullagh/drizzle/bug-fix-572633

It would be great if you could just run a compile on this branch to confirm that the errors have been fixed before I propose it for merge.

You may also run into some other compile errors further along. Then I can fix them as well.

Thanks,

Paul

Changed in drizzle:
assignee: Monty Taylor (mordred) → Paul McCullagh (paul-mccullagh)
Revision history for this message
BJ Dierkes (derks) wrote : Re: [Bug 572633] Re: pbxt build errors [-Wsign-compare]
Download full text (3.7 KiB)

Thanks Paul,

I added the patch and now get:

  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ha_xtsys.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-hashtab_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-heap_xt.lo
  CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-index_xt.lo
cc1plus: warnings being treated as errors
plugin/pbxt/src/index_xt.cc: In function 'unsigned int idx_dirty_blocks(XTTable*)':
plugin/pbxt/src/index_xt.cc:1855: warning: comparison between signed and unsigned integer expressions
make[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-index_xt.lo] Error 1
make[2]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
make: *** [install] Error 2

---
derks

On May 3, 2010, at 7:31 AM, Paul McCullagh wrote:

> Hi BJ,
>
> I have made some changes that should fix the compile errors you reported
> above.
>
> The changes are in: lp:~paul-mccullagh/drizzle/bug-fix-572633
>
> It would be great if you could just run a compile on this branch to
> confirm that the errors have been fixed before I propose it for merge.
>
> You may also run into some other compile errors further along. Then I
> can fix them as well.
>
> Thanks,
>
> Paul
>
>
> ** Branch linked: lp:~paul-mccullagh/drizzle/bug-fix-572633
>
> ** Changed in: drizzle
> Assignee: Monty Taylor (mordred) => Paul McCullagh (paul-mccullagh)
>
> --
> pbxt build errors [-Wsign-compare]
> https://bugs.launchpad.net/bugs/572633
> You received this bug notification because you are a member of Drizzle-
> developers, which is subscribed to Drizzle.
>
> Status in A Lightweight SQL Database for Cloud and Web: Confirmed
> Status in Drizzle dexter series: New
>
> Bug description:
> Confirmed on RHEL 5, Fedora 12:
>
> CXXLD plugin/libmysql_protocol_plugin.la
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
> cc1plus: warnings being treated as errors
> plugin/pbxt/src/filesys_xt.cc: In function 'int xt_pwrite_file(XTOpenFile*, off_t, size_t, void*, XTIOStats*, XTThread*)':
> plugin/pbxt/src/filesys_xt.cc:1506: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
> plugin/pbxt/src/fil...

Read more...

Revision history for this message
Monty Taylor (mordred) wrote :
Download full text (4.0 KiB)

On 05/03/2010 09:42 AM, BJ Dierkes wrote:
> Thanks Paul,
>
> I added the patch and now get:
>
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ha_xtsys.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-hashtab_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-heap_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-index_xt.lo
> cc1plus: warnings being treated as errors
> plugin/pbxt/src/index_xt.cc: In function 'unsigned int idx_dirty_blocks(XTTable*)':
> plugin/pbxt/src/index_xt.cc:1855: warning: comparison between signed and unsigned integer expressions
> make[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-index_xt.lo] Error 1
> make[2]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
> make[1]: *** [install-recursive] Error 1
> make[1]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
> make: *** [install] Error 2
>
> ---
> derks
>
>
> On May 3, 2010, at 7:31 AM, Paul McCullagh wrote:
>
>> Hi BJ,
>>
>> I have made some changes that should fix the compile errors you reported
>> above.
>>
>> The changes are in: lp:~paul-mccullagh/drizzle/bug-fix-572633
>>
>> It would be great if you could just run a compile on this branch to
>> confirm that the errors have been fixed before I propose it for merge.
>>
>> You may also run into some other compile errors further along. Then I
>> can fix them as well.
>>
>> Thanks,
>>
>> Paul
>>
>>
>> ** Branch linked: lp:~paul-mccullagh/drizzle/bug-fix-572633
>>
>> ** Changed in: drizzle
>> Assignee: Monty Taylor (mordred) => Paul McCullagh (paul-mccullagh)
>>
>> --
>> pbxt build errors [-Wsign-compare]
>> https://bugs.launchpad.net/bugs/572633
>> You received this bug notification because you are a member of Drizzle-
>> developers, which is subscribed to Drizzle.
>>
>> Status in A Lightweight SQL Database for Cloud and Web: Confirmed
>> Status in Drizzle dexter series: New
>>
>> Bug description:
>> Confirmed on RHEL 5, Fedora 12:
>>
>> CXXLD plugin/libmysql_protocol_plugin.la
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
>> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
>> cc1plus: warnings being treated as errors
>> plugin/pbxt/src/filesys_xt.cc: In function 'int xt_pwrite_file(XTOpenFile*, off_t, size_t, void*, XTIOStats*, XTT...

Read more...

Revision history for this message
BJ Dierkes (derks) wrote :
Download full text (54.8 KiB)

This is the output of 'make -k':

make[5]: Entering directory `/builddir/build/BUILD/drizzle-2010.04.1513'
srcdir=. ./config/make-lint.py
make[5]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
  CC libgnu_la-dummy.lo
  CCLD libgnu.la
make[4]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513/gnulib'
make[3]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513/gnulib'
make[2]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513/gnulib'
Making all in .
make[2]: Entering directory `/builddir/build/BUILD/drizzle-2010.04.1513'
srcdir=. ./config/make-lint.py
  CXX drizzled/message/drizzled_message_libdrizzledmessage_la-statement_transform.lo
  CXX drizzled/message/drizzled_message_libdrizzledmessage_la-master_list.pb.lo
drizzled/message/master_list.pb.cc: In copy constructor 'drizzle::MasterList_Record::MasterList_Record(const drizzle::MasterList_Record&)':
drizzled/message/master_list.pb.cc:148: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/master_list.pb.cc: In copy constructor 'drizzle::MasterList::MasterList(const drizzle::MasterList&)':
drizzled/message/master_list.pb.cc:645: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
  CXX drizzled/message/drizzled_message_libdrizzledmessage_la-transaction.pb.lo
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::FieldMetadata::FieldMetadata(const drizzled::message::FieldMetadata&)':
drizzled/message/transaction.pb.cc:735: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::TableMetadata::TableMetadata(const drizzled::message::TableMetadata&)':
drizzled/message/transaction.pb.cc:1001: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::TransactionContext::TransactionContext(const drizzled::message::TransactionContext&)':
drizzled/message/transaction.pb.cc:1280: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::InsertRecord::InsertRecord(const drizzled::message::InsertRecord&)':
drizzled/message/transaction.pb.cc:1594: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::InsertHeader::InsertHeader(const drizzled::message::InsertHeader&)':
drizzled/message/transaction.pb.cc:1792: warning: base class 'class google::protobuf::Message' should be explicitly initialized in the copy constructor [-Wextra]
drizzled/message/transaction.pb.cc: In copy constructor 'drizzled::message::InsertData::InsertData(const drizzled::message::InsertData&)':
drizzled/message/transaction.pb.cc:2046: warning: base...

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Derks,

Thanks for the additional information. I have fixed the 2 errors reported above. I pushed the fixes to lp:~paul-mccullagh/drizzle/bug-fix-572633 as before.

Please check again if Drizzle now compiles. Thanks!

Revision history for this message
BJ Dierkes (derks) wrote :

Looks good. Added, and built successfully. Thanks Paul!

---
derks

On May 4, 2010, at 4:53 AM, Paul McCullagh wrote:

> Hi Derks,
>
> Thanks for the additional information. I have fixed the 2 errors
> reported above. I pushed the fixes to lp:~paul-mccullagh/drizzle/bug-
> fix-572633 as before.
>
> Please check again if Drizzle now compiles. Thanks!
>
> --
> pbxt build errors [-Wsign-compare]
> https://bugs.launchpad.net/bugs/572633
> You received this bug notification because you are a member of Drizzle-
> developers, which is subscribed to Drizzle.
>
> Status in A Lightweight SQL Database for Cloud and Web: Confirmed
> Status in Drizzle dexter series: New
>
> Bug description:
> Confirmed on RHEL 5, Fedora 12:
>
> CXXLD plugin/libmysql_protocol_plugin.la
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-ccutils_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-database_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datadic_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-datalog_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-discover_xt.lo
> CXX plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo
> cc1plus: warnings being treated as errors
> plugin/pbxt/src/filesys_xt.cc: In function 'int xt_pwrite_file(XTOpenFile*, off_t, size_t, void*, XTIOStats*, XTThread*)':
> plugin/pbxt/src/filesys_xt.cc:1506: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
> plugin/pbxt/src/filesys_xt.cc:1530: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
> plugin/pbxt/src/filesys_xt.cc: In function 'int xt_flush_file(XTOpenFile*, XTIOStats*, XTThread*)':
> plugin/pbxt/src/filesys_xt.cc:1758: error: comparison between signed and unsigned integer expressions [-Wsign-compare]
> make[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-filesys_xt.lo] Error 1
> make[2]: Leaving directory `/builddir/build/BUILD/drizzle-2010.04.1513'
> make[1]: *** [install-recursive] Error 1
> make[1]: Leaving directory `/
>
>

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Great! Then I will propose the branch for merge... :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.