Build Fails : --without-myisam-plugin

[Jobin Augustine]

While validating the plugin detachablity,
it appears that there is few dependency exists between the the Kernel and MyISAM plugin / Module
Since default storage is InnoDB, idealy MyISAM should be detachable.
most of the pluggins are validated for the detachability.

/home/jobin/bzrwork/drizzle/drizzled/session.cc:1960: undefined reference to `reset_key_cache_counters'
set_var.o: In function `sys_var_key_cache_param::value_ptr(Session*, enum_var_type, st_mysql_lex_string const*)':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1226: undefined reference to `dflt_key_cache'
set_var.o: In function `resize_key_cache_with_lock':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
set_var.o: In function `sys_var_key_cache_uint32_t::update(Session*, set_var*)':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1313: undefined reference to `dflt_key_cache'
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1323: undefined reference to `dflt_key_cache'
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1327: undefined reference to `dflt_key_cache'
set_var.o: In function `resize_key_cache_with_lock':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
set_var.o: In function `sys_var_key_cache_uint32_t::update(Session*, set_var*)':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1330: undefined reference to `dflt_key_cache'
set_var.o: In function `sys_var_key_buffer_size::update(Session*, set_var*)':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1259: undefined reference to `dflt_key_cache'
set_var.o: In function `resize_key_cache_with_lock':
/home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
table.o: In function `Table::create_myisam_tmp_table(st_key*, st_columndef*, st_columndef**, unsigned long)':
/home/jobin/bzrwork/drizzle/drizzled/table.cc:3197: undefined reference to `mi_create'
../plugin/.libs/libheap_plugin.a(hp_create.o): In function `keys_compare':
/home/jobin/bzrwork/drizzle/plugin/heap/hp_create.cc:390: undefined reference to `ha_key_cmp'
../plugin/.libs/libinfo_schema_plugin.a(plugin_libinfo_schema_plugin_la-info_schema_methods.o): In function `show_status_array':
/home/jobin/bzrwork/drizzle/plugin/info_schema/info_schema_methods.cc:179: undefined reference to `dflt_key_cache'
/home/jobin/bzrwork/drizzle/plugin/info_schema/info_schema_methods.cc:175: undefined reference to `dflt_key_cache'

steps:
$> ./configure --without-myisam-plugin
$> make

Thank you,
Jobin.

[Monty Taylor (mordred)]

Indeed. MyISAM is still not quite extricated from the internals. I'll be
taking care of the set_var ones soon as part of plugin variable
reworking. That will probably get reset_key_cache_counters as well and
hopefully the info_schema references.

This leaves only table.cc and hp_create.cc unaccounted for.

Of course, we still require MyISAM at the moment for internal temp
tables - but that should really be more of its own plugin interface that
we merely require at least one implementation of, IMHO.

Monty

Jobin Augustine wrote:
> Public bug reported:
>
> While validating the plugin detachablity,
> it appears that there is few dependency exists between the the Kernel and MyISAM plugin / Module
> Since default storage is InnoDB, idealy MyISAM should be detachable.
> most of the pluggins are validated for the detachability.
>
> /home/jobin/bzrwork/drizzle/drizzled/session.cc:1960: undefined reference to `reset_key_cache_counters'
> set_var.o: In function `sys_var_key_cache_param::value_ptr(Session*, enum_var_type, st_mysql_lex_string const*)':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1226: undefined reference to `dflt_key_cache'
> set_var.o: In function `resize_key_cache_with_lock':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
> set_var.o: In function `sys_var_key_cache_uint32_t::update(Session*, set_var*)':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1313: undefined reference to `dflt_key_cache'
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1323: undefined reference to `dflt_key_cache'
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1327: undefined reference to `dflt_key_cache'
> set_var.o: In function `resize_key_cache_with_lock':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
> set_var.o: In function `sys_var_key_cache_uint32_t::update(Session*, set_var*)':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1330: undefined reference to `dflt_key_cache'
> set_var.o: In function `sys_var_key_buffer_size::update(Session*, set_var*)':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1259: undefined reference to `dflt_key_cache'
> set_var.o: In function `resize_key_cache_with_lock':
> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined reference to `resize_key_cache'
> table.o: In function `Table::create_myisam_tmp_table(st_key*, st_columndef*, st_columndef**, unsigned long)':
> /home/jobin/bzrwork/drizzle/drizzled/table.cc:3197: undefined reference to `mi_create'
> ../plugin/.libs/libheap_plugin.a(hp_create.o): In function `keys_compare':
> /home/jobin/bzrwork/drizzle/plugin/heap/hp_create.cc:390: undefined reference to `ha_key_cmp'
> ../plugin/.libs/libinfo_schema_plugin.a(plugin_libinfo_schema_plugin_la-info_schema_methods.o): In function `show_status_array':
> /home/jobin/bzrwork/drizzle/plugin/info_schema/info_schema_methods.cc:179: undefined reference to `dflt_key_cache'
> /home/jobin/bzrwork/drizzle/plugin/info_schema/info_schema_methods.cc:175: undefined reference to `dflt_key_cache'
>
> steps:
> $> ./configure --without-myisam-plugin
> $> make
>
> Thank you,
> Jobin.
>
> ** Affects: drizzle
> ...

[Brian Aker (brianaker)]

Hi!

We could hide it... there are flags for this, but yes, we still need
it for internal temp tables to disk.

Cheers,
 -Brian

On Oct 22, 2009, at 10:21 AM, Monty Taylor wrote:

> Indeed. MyISAM is still not quite extricated from the internals.
> I'll be
> taking care of the set_var ones soon as part of plugin variable
> reworking. That will probably get reset_key_cache_counters as well and
> hopefully the info_schema references.
>
> This leaves only table.cc and hp_create.cc unaccounted for.
>
> Of course, we still require MyISAM at the moment for internal temp
> tables - but that should really be more of its own plugin interface
> that
> we merely require at least one implementation of, IMHO.
>
> Monty
>
> Jobin Augustine wrote:
>> Public bug reported:
>>
>> While validating the plugin detachablity,
>> it appears that there is few dependency exists between the the
>> Kernel and MyISAM plugin / Module
>> Since default storage is InnoDB, idealy MyISAM should be detachable.
>> most of the pluggins are validated for the detachability.
>>
>> /home/jobin/bzrwork/drizzle/drizzled/session.cc:1960: undefined
>> reference to `reset_key_cache_counters'
>> set_var.o: In function `sys_var_key_cache_param::value_ptr
>> (Session*, enum_var_type, st_mysql_lex_string const*)':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1226: undefined
>> reference to `dflt_key_cache'
>> set_var.o: In function `resize_key_cache_with_lock':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined
>> reference to `resize_key_cache'
>> set_var.o: In function `sys_var_key_cache_uint32_t::update
>> (Session*, set_var*)':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1313: undefined
>> reference to `dflt_key_cache'
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1323: undefined
>> reference to `dflt_key_cache'
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1327: undefined
>> reference to `dflt_key_cache'
>> set_var.o: In function `resize_key_cache_with_lock':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined
>> reference to `resize_key_cache'
>> set_var.o: In function `sys_var_key_cache_uint32_t::update
>> (Session*, set_var*)':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1330: undefined
>> reference to `dflt_key_cache'
>> set_var.o: In function `sys_var_key_buffer_size::update(Session*,
>> set_var*)':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1259: undefined
>> reference to `dflt_key_cache'
>> set_var.o: In function `resize_key_cache_with_lock':
>> /home/jobin/bzrwork/drizzle/drizzled/set_var.cc:1247: undefined
>> reference to `resize_key_cache'
>> table.o: In function `Table::create_myisam_tmp_table(st_key*,
>> st_columndef*, st_columndef**, unsigned long)':
>> /home/jobin/bzrwork/drizzle/drizzled/table.cc:3197: undefined
>> reference to `mi_create'
>> ../plugin/.libs/libheap_plugin.a(hp_create.o): In function
>> `keys_compare':
>> /home/jobin/bzrwork/drizzle/plugin/heap/hp_create.cc:390: undefined
>> reference to `ha_key_cmp'
>> ../plugin/.libs/libinfo_schema_plugin.a
>> (plugin_libinfo_schema_plugin_la-info_schema_methods.o): In
>> function `show_status_array':
>> /home...

[Stewart Smith (stewart)]

On Thu, Oct 22, 2009 at 05:21:48PM -0000, Monty Taylor wrote:
> Indeed. MyISAM is still not quite extricated from the internals. I'll be
> taking care of the set_var ones soon as part of plugin variable
> reworking. That will probably get reset_key_cache_counters as well and
> hopefully the info_schema references.
>
> This leaves only table.cc and hp_create.cc unaccounted for.
>
> Of course, we still require MyISAM at the moment for internal temp
> tables - but that should really be more of its own plugin interface that
> we merely require at least one implementation of, IMHO.

The code for internal temp tables is quite a mess*, it'll get there at
some point "soon".

* s/quite/favourite expletive related to excrement/

--
Stewart Smith

[Stewart Smith (stewart)]

I gather this is a "now compiles" and not "now remotely works"

[Monty Taylor (mordred)]

Stewart Smith wrote:
> I gather this is a "now compiles" and not "now remotely works"
>

This is now fixed in that "--without-myisam-plugin" is no longer an
option, since it's not something that will do anything valid. This is a
generalized thing - any static plugin can't be disabled. :)